Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modelStudio fails on R v4.2 (devel) due to changes in logical operators #107

Closed
hbaniecki opened this issue Feb 27, 2022 · 1 comment
Closed

modelStudio fails on R v4.2 (devel) due to changes in logical operators #107

hbaniecki opened this issue Feb 27, 2022 · 1 comment
Labels
bug 💣 Bug to fix short term ⏰ TODO short term

Comments

@hbaniecki
Copy link
Member

hbaniecki commented Feb 27, 2022 •
edited
Loading

In R News we read:

Calling && or || with an argument of length greater than one now gives a warning (and it is intended that will eventually become an error).

This broke the following line of code in the r2d3 package (v0.2.5):
https://github.com/rstudio/r2d3/blame/388585b7f863f9ec0c9549a77025908e1fb37ecb/R/script.R#L33

Which produced warnings in modelStudio(); thus, errors in CRAN checks.

Should be solved when r2d3 v0.2.6 arrives at CRAN. rstudio/r2d3#98
@hbaniecki hbaniecki added bug 💣 Bug to fix short term ⏰ TODO short term labels Feb 27, 2022
@hbaniecki hbaniecki changed the title modelStudio fails on R v4.2 due to changes in logical operators modelStudio fails on R v4.2 (devel) due to changes in logical operators Feb 27, 2022
@hbaniecki
Copy link
Member Author

First devel checks seem to pass.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 💣 Bug to fix short term ⏰ TODO short term
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hbaniecki