Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine text for gas masks is broken. #2525

Open
Joel-682 opened this issue May 18, 2024 · 3 comments
Open

Examine text for gas masks is broken. #2525

Joel-682 opened this issue May 18, 2024 · 3 comments

Comments

@Joel-682
Copy link

Joel-682 commented May 18, 2024

Issue Summary

Round ID: 286

Testmerges:

#2482
#2459

Reproduction:

image

Whenever a gas mask is examined, at least by a ghost, they return no text. If it is examined again, one gets the "You examine the gas mask closer, but find nothing of interest"

Steps for reproduction:

  1. In the map MiniMammoth, observe.
  2. Go to the irradiated vault (Photo here
    image
    )
  3. Examine the gas mask above the skeleton. You won't see anything.
  4. Examine it again to get the "You examine the gas mask closer, but find nothing of interest" message
@Joel-682
Copy link
Author

So, it's not just /obj/item/clothing/mask/gas/ms13/modern, but every mask with "/obj/item/clothing/mask/gas/ms13". Masks from the base game (/obj/item/clothing/mask/gas) have their examine work. I presume this may have something to do with the traits of /obj/item/clothing/mask/gas/ms13.

@Joel-682
Copy link
Author

After playing a bit with the variables in /obj/item/clothing/mask/gas/ms13, I believe that it isn't a problem. Despite letting it inherit all the variables from /obj/item/clothing/mask/gas, the examine still doesn't work.

I love code, someone smarter than me fix this. I think the examine verb may be broken in regards to gas masks?

@ProfessorPopoff
Copy link
Contributor

I know what's causing the issue- I cut it off and forgot about it. I'll have it fixed and filled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants