Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux wine script #35

Open
harry-cpp opened this issue Aug 1, 2024 · 6 comments
Open

Update Linux wine script #35

harry-cpp opened this issue Aug 1, 2024 · 6 comments

Comments

@harry-cpp
Copy link
Member

Some distros might not add wine64 to the bin folder. Check to see if we need to check some custom folder, or if just running wine gets us a 64 bit version and prefix.

@AristurtleDev
Copy link
Contributor

Commented on the original PR that was closed, but I’ll add here as well

@harry-cpp the setup script checks for the existence of wine64 by using the command itself. If it’s installed correctly, which means it’s added to $PATH, or in a directory that’s in $PATH, then that verifies it:

If the script is updated to check if it’s installed in different locations, that will work, but then later mgcb will fail when it attempts to compile shaders because the command isn’t in $PATH.

Users should ensure the wine64 command is valid in $PATH, the script shouldn’t be updated to check various locations. We can’t account for every possible location a user may install it.

@harry-cpp
Copy link
Member Author

We can check a set of default different common install locations for the binary, both for script and mgcb, it doesn't cost us anything to do.

If you install wine in some custom way, well, you should know better on how to fix issues that might crop up due to it, no need for us to try and support it.

Also we officially only support Ubuntu for the development on Linux, we do try to fix issues for other distros but we don't plan to have docs supporting them.

@AristurtleDev
Copy link
Contributor

If only Ubuntu is officially supported in docs and the script, then the script needs no adjustments. When the script was made, it was tested against both Ubuntu 22.04 (LTS) and macOS. Following the current steps in the documentation will always lead to the script passing the wine64 check on both of those operating systems.

@harry-cpp
Copy link
Member Author

@AristurtleDev

we do try to fix issues for other distros but we don't plan to have docs supporting them.

@AristurtleDev
Copy link
Contributor

@harry-cpp

I understand the statement, but supporting it in the script and not documents seems like it could become a maintenance nightmare. So we adjust the script today for Linux Mint so it checks in /user/lib/ as well as the default of /user/bin/wine64 like where it is in Ubuntu.

So tomorrow someone comes in with Arch Linux, and maybe there by default it's in /bin
Then someone comes in with Fedora and it's in /user/bin/lib

(these are hypothetical locations but you get my point).

Where do we draw the line and say "Ok we've got 10 different location checks, no more will be added"

or the documentation is update to just say to ensure wine64 is in PATH, and maybe change the error message in the script to state that it couldn't be found and if installed to ensure it's in PATH

@harry-cpp
Copy link
Member Author

If its somethig too complex to make it work, we definetly won't add support for some random distro.

But this issue is very easy to make it work out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants