Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using custom properties for assets #440

Open
1 task done
zNightlord opened this issue Jul 8, 2023 · 2 comments · May be fixed by #572
Open
1 task done

Using custom properties for assets #440

zNightlord opened this issue Jul 8, 2023 · 2 comments · May be fixed by #572
Assignees
@zNightlord
Labels
enhancement Feature requests or new functionality suggestions first good contribution This issue makes a good first submission for someone looking to contribute to MCprep

Comments

@zNightlord
Copy link
Contributor

Check against existing requests

  • I have checked existing feature requests, and my idea is different

Describe the context

"mob_skip_prep" "make_real" are defined in the
mcprep data update json
I find this inconvenient in some way.

So I propose to move to custom properties.
Custom Properties can be user added in and read through the API. Custom properties
We can also set custom properties after doing certain operation.

Another name for this is "Extend MCprep attributes" because OBJ importer use this also

How do you imagine your feature works?

For material we introduce something like NO_PREP or SKIP_PREP custom properties with 1 value with that we can bring that information in so it doesn't clear the existing nodes in certain rig material.
Same for collection in meshswap blend file for make real but the operator parameter can override it.

What existing workaround (or closest thing to a workaround) do you have today (within Blender, MCprep, or any software)? If there is no workaround, explain why you feel this way.

Beside custom properties there is asset tag but it is in 3.0, we can't really use that.
@zNightlord zNightlord added the enhancement Feature requests or new functionality suggestions label Jul 8, 2023
@StandingPadAnimations StandingPadAnimations added this to the v3.5.1 milestone Jul 8, 2023
@StandingPadAnimations StandingPadAnimations added the first good contribution This issue makes a good first submission for someone looking to contribute to MCprep label Jul 8, 2023
@StandingPadAnimations
Copy link
Collaborator

Marked this for 3.5.1 (albeit low priority)

@TheDuckCow TheDuckCow moved this from Todo to In Progress in MCprep Dev Team Jul 23, 2023
@zNightlord
Copy link
Contributor Author

Here are some properties I can bring up

Material:

  • MCPREP_NOPREP (bool): Bypass the prep material
  • MCPREP_MOBTYPE (string): Name of vanilla mob material, useful for mob skin like villager in skinswap handle profession, level, type texture
  • MCPREP_HASCOLOR (bool): Material possibly has another color variation for skin swap

Object or Collection:

  • MCPREP_MOBTYPE (string): Like above, maybe can have "CUSTOM" if not a mob rig

  • MCPREP_RIGVERSION (string): a string (blender) versioning of a rig, I was thinking about not import the rig through bAppendLink() load use case

  • MCPREP_MAKEREAL (bool): For realize the rig

  • MCPREP_MAKESWAP (bool): This already exist, meshswap noimport suffix in meshswap.blend

  • MCPREP_NOSWAP (bool): This already exist added when spawn using meshswap spawner

Is the naming convention good? Or something need to be added?

@TheDuckCow TheDuckCow modified the milestones: v3.5.1, v3.5.2 Nov 15, 2023
@zNightlord zNightlord mentioned this issue Apr 15, 2024
Merged
@StandingPadAnimations StandingPadAnimations removed this from the v3.5.3 milestone Apr 15, 2024
@zNightlord zNightlord linked a pull request May 10, 2024 that will close this issue
Draft
@StandingPadAnimations StandingPadAnimations linked a pull request Jul 8, 2024 that will close this issue
WIP - Other rig properties, mob type, color variant #572
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zNightlord zNightlord

Labels
enhancement Feature requests or new functionality suggestions first good contribution This issue makes a good first submission for someone looking to contribute to MCprep
Projects
MCprep Dev Team
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP - Other rig properties, mob type, color variant zNightlord/MCprep
3 participants
@TheDuckCow @zNightlord @StandingPadAnimations