Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireguard usermod folder not included #137

Open
1 task done
jameskennemore opened this issue Jun 3, 2024 · 2 comments
Open
1 task done

Wireguard usermod folder not included #137

jameskennemore opened this issue Jun 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jameskennemore
Copy link

What happened?

The wireguard usermods directory doesn't exist, although wireguard is referenced in const.h. When re-adding the wireguard usermod directory and platformio_override.ini, Wireguard configuration options aren't in the Usermods config page after building. (It works in the non-MM build.)

To Reproduce Bug

Add the wireguard usermod directory and platformio_override.ini, then build. Wireguard configuration options aren't in the Usermods config page.

Expected Behavior

Wireguard config options should be in the Usermods config page after adding the wireguard usermod.

Install Method

Self-Compiled or other

What version/release of MM WLED?

MoonModules v0.14.1-b30

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jameskennemore jameskennemore added the bug Something isn't working label Jun 3, 2024
@jameskennemore
Copy link
Author

Added it back to the usermods_list.cpp and the configuration returned:
#ifdef USERMOD_WIREGUARD
usermods.add(new WireguardUsermod());
#endif
#ifdef USERMOD_WIREGUARD
#include "../usermods/wireguard/wireguard.h"
#endif

@softhack007
Copy link
Collaborator

Hi, I'm not sure this usermod would work in MM.

We don't have the changes from upstream that allow accessing UI pages from behind a proxy (Aircoookie#3238). Not sure if wireguard relies on this feature (I don't have a setup for testing).

@softhack007 softhack007 added enhancement New feature or request and removed bug Something isn't working labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants