Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotary (alt): effects skipped when no speed/intensity slider exists #25

Open
1 task done
softhack007 opened this issue Mar 20, 2023 · 0 comments
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@softhack007
Copy link
Collaborator

softhack007 commented Mar 20, 2023

What happened?

Some effects (example, Hiphotic) seem to not allow editing of "Effect Speed" and "Effect Intensity" - they are just skipped over
I'm guessing it's due to these lines:

case  1: if (!extractModeSlider(effectCurrent, 0, lineBuffer, 63)) newState++; else changedState = true; break; // speed
case  2: if (!extractModeSlider(effectCurrent, 1, lineBuffer, 63)) newState++; else changedState = true; break; // intensity

Thanks to Troy for reporting this problem.
It seems to also happen like this in upstream

Install Method

Self-Compiled or other

What version/release of MM WLED?

2303150

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@softhack007 softhack007 added the bug Something isn't working label Mar 20, 2023
@softhack007 softhack007 self-assigned this Mar 20, 2023
@softhack007 softhack007 changed the title Rotary (alt) effects skipped when no speed/intensity slider exists Rotary (alt): effects skipped when no speed/intensity slider exists Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant