Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce liq_cue_skip and fix bugs #37

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

t0mtaylor
Copy link

@t0mtaylor t0mtaylor commented Aug 12, 2024

proposed v4.2.0 with new options:

Reason for change: To allow rerun of cue_file within a script over files sync'd and so it wont reprocess files that have already been processed and tagged

The added benefit of the liq_cue_skip tag also now stops the file metadata/tags being written again to the media file, which would cause the modified date to change when it doesn't need to. This causes a nightmare for bi-direction sync.

  • Introduce skip arg and liq_cue_skip tag for files to avoid reprocessing by force, as current logic doesn't seem to work as expected, this is backwards compatible with previously processed files and not a breaking change. Files may require reprocessing one time to add the new tag where required.

  • The liq_cue_file must be true when skip is enabled, to allow Azuracast to read the tags and avoid any more re-processing, - although when true Azuracast outputs:cue_file results override existing metadata because liq_cue_file=true tells us to. which means Azuracast may need to support the skip tag to be forced to just read the tags when this is true.

  • fix Mutagen m4a python TypeError: encoding without a string argument on Mac when writing tags for m4a/mp4 files (should be string).

  • Add debug flag to allow some additional messages when required

example command line, which includes write, replygain, skip (-p), debug (-z):

./cue_file "filename.mp3" -wrpz

force will still work if required, or you remove skip for existing checks

@t0mtaylor
Copy link
Author

testing with original skip_analysis, which works as expected after a file was processed with liq_cue_skip and when skip arg mode is not enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant