Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wd-input-number自定义按钮图标 #504

Closed

Conversation

ssuperlilei
Copy link
Contributor

@ssuperlilei ssuperlilei commented Aug 8, 2024

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

issue

💡 需求背景和解决方案

  1. 可以自定义 input-number 的图标
  2. 添加 left-icon 和 right-icon 插槽

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新特性

    • InputNumber 组件中新增了左侧和右侧图标的插槽,提升了图标自定义灵活性。
  • 文档

    • 优化了 InputNumber 组件文档的格式和结构,增强了可读性。
    • 增加了插槽部分的详细说明,提供了更清晰的定制指导。

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit ecac877
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66b49c6072ca8c0008c871dd
😎 Deploy Preview https://deploy-preview-504--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 10:23am

Copy link

coderabbitai bot commented Aug 8, 2024

Walkthrough

此次变更主要集中在InputNumber组件的文档和实现中,增加了图标自定义的命名插槽,改善了文档的结构与可读性。文档中新增了插槽部分,详细说明了left-iconright-icon的用法,使用户能够更灵活地定制图标。此外,文档格式的优化也提升了整体可读性。

Changes

文件路径 变更摘要
docs/component/input-number.md 增加插槽部分,清晰描述left-iconright-icon的用法;改善文档格式,提高可读性。
src/uni_modules/wot-design-uni/components/wd-input-number/wd-input-number.vue 替换静态图标为命名插槽,允许用户自定义图标,增强组件的可用性。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant InputNumber
    participant SlotIcons

    User->>InputNumber: 输入数字
    InputNumber->>SlotIcons: 渲染左侧图标
    InputNumber->>SlotIcons: 渲染右侧图标
    SlotIcons-->>InputNumber: 返回自定义图标
    InputNumber-->>User: 显示输入框及图标
Loading

Poem

在数字的世界里跳跃,
小兔子欢快地歌唱,
新图标闪耀如星星,
自定义的乐趣无穷。
点击间,变化无常,
让我们的输入更闪亮! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0e6ea3e and ecac877.

Files selected for processing (2)
  • docs/component/input-number.md (3 hunks)
  • src/uni_modules/wot-design-uni/components/wd-input-number/wd-input-number.vue (2 hunks)
Additional comments not posted (2)
docs/component/input-number.md (1)

126-131: 新增插槽文档部分

插槽部分的新增为用户提供了关于自定义图标的清晰指导。描述准确且与文档其余部分保持一致。

src/uni_modules/wot-design-uni/components/wd-input-number/wd-input-number.vue (1)

4-6: 引入图标自定义插槽

通过使用 left-iconright-icon 插槽,组件的灵活性得到了增强,符合PR目标。实现正确且未引入任何问题。

Also applies to: 23-25

@elarbor
Copy link

elarbor commented Sep 30, 2024

其实咱们的组件库也不用内置图标,主要是太少不够用。使用unocss+iconify的图标库就很方便。二十多万的图标总有适合自己的
image
image
image

希望咱们的组件库能直接内置

@Moonofweisheng
Copy link
Owner

其实咱们的组件库也不用内置图标,主要是太少不够用。使用unocss+iconify的图标库就很方便。二十多万的图标总有适合自己的 image image image

希望咱们的组件库能直接内置

可以考虑。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants