Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep_non_zero_percentage should work with either 0 or NA #29

Open
rmflight opened this issue Dec 4, 2023 · 0 comments
Open

keep_non_zero_percentage should work with either 0 or NA #29

rmflight opened this issue Dec 4, 2023 · 0 comments
Assignees
@rmflight

Comments

@rmflight
Copy link
Member

rmflight commented Dec 4, 2023

Right now it only works with zero values. Which is silly. Missing should be either zero or NA, or one or the other.

I would use the same trick we use in ici_kendalltau, where we can create a vector of missing values.
@rmflight rmflight self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmflight rmflight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmflight