Shutdown motion when file:// reached EOF #1501

tosiara · 2020-02-28T10:20:42Z

tosiara
Feb 28, 2020
Maintainer

From mail list: https://sourceforge.net/p/motion/mailman/message/36933843/

Since file:// is used to reprocess recordings either from motion to tune settings, or from 3rd party DVR, it would make sense to exit as soon as the whole file processed

Current behaivior: rewind the file and start over forever

Suggested patch:

diff --git a/src/netcam_rtsp.c b/src/netcam_rtsp.c
index 63ac614..4ec1f70 100644
--- a/src/netcam_rtsp.c
+++ b/src/netcam_rtsp.c
@@ -621,6 +621,12 @@ static int netcam_rtsp_read_image(struct rtsp_context *rtsp_data){
                 ,errstr, rtsp_data->interrupted ? _("True"):_("False"));
             my_packet_unref(rtsp_data->packet_recv);
             netcam_rtsp_close_context(rtsp_data);
+
+            // if processing of file:// completed - shutdown motion
+            if (!strcmp(rtsp_data->service, "file") && !strcmp(errstr, "End of file")) {
+                MOTION_LOG(ERR, TYPE_NETCAM, NO_ERRNO, "\"%s\" file:// stream detected, process completed, shutdown", errstr);
+                rtsp_data->finish = TRUE;
+            }
             return -1;
         }

rdorsch · 2020-02-29T18:40:20Z

rdorsch
Feb 29, 2020

Hmm....no, I do not see that this patch fixes the issue. I still get the loops and the reconnect:


[2:nc2:Cam0-replay] [INF] [NET] [Feb 29 19:35:38] netcam_rtsp_read_image: Normal resolution: av_read_frame: End of file ,Interrupt: False
[2:nc2:Cam0-replay] [ERR] [NET] [Feb 29 19:35:38] netcam_rtsp_handler_reconnect: Normal resolution: Reconnecting with camera....
[2:nc2:Cam0-replay] [INF] [NET] [Feb 29 19:35:38] netcam_rtsp_set_file: Normal resolution: Setting attributes to read file
[2:nc2:Cam0-replay] [INF] [NET] [Feb 29 19:35:38] netcam_rtsp_open_context: Normal resolution: Opened camera(Cam0-replay)
[2:nc2:Cam0-replay] [NTC] [NET] [Feb 29 19:35:38] netcam_rtsp_connect: Normal resolution: Camera (Cam0-replay) connected

Also I double checked that the patch did correctly apply.

0 replies

tosiara · 2020-03-02T09:08:41Z

tosiara
Mar 2, 2020
Maintainer Author

Check this patch:

diff --git a/src/netcam_rtsp.c b/src/netcam_rtsp.c
index 63ac614..2de1d8f 100644
--- a/src/netcam_rtsp.c
+++ b/src/netcam_rtsp.c
@@ -616,9 +616,17 @@ static int netcam_rtsp_read_image(struct rtsp_context *rtsp_data){
         if ((rtsp_data->interrupted) || (retcd < 0)) {
             av_strerror(retcd, errstr, sizeof(errstr));
             MOTION_LOG(INF, TYPE_NETCAM, NO_ERRNO
-                ,_("%s: av_read_frame: %s ,Interrupt: %s")
-                ,rtsp_data->cameratype
+                ,_("%s: service: %s, av_read_frame: %s, Interrupt: %s")
+                ,rtsp_data->cameratype, rtsp_data->service
                 ,errstr, rtsp_data->interrupted ? _("True"):_("False"));
+            // if processing of file:// completed - shutdown motion
+
+            if (!strcmp(rtsp_data->service, "file") && !strcmp(errstr, "End of file")) {
+                MOTION_LOG(ERR, TYPE_NETCAM, NO_ERRNO, "\"%s\" file:// stream detected, process completed, shutdown", errstr);
+                rtsp_data->status = RTSP_NOTCONNECTED;
+                rtsp_data->finish = TRUE;
+            }
+
             my_packet_unref(rtsp_data->packet_recv);
             netcam_rtsp_close_context(rtsp_data);
             return -1;

For some reason I cannot force my motion to exit. It finishes reading file, but keeps running for some reason

0 replies

rdorsch · 2020-03-02T21:49:59Z

rdorsch
Mar 2, 2020

Hmm, weired, here it keeps looping, though the "reconnecting ..." in the log is gone: [1:ml1:Cam0-replay] [INF] [ALL] [Mar 02 22:45:46] mlp_setupmode: Raw changes: 1663 - changes after 'EedDl': 293 - labels: 2 - noise level: 11 [1:ml1:Cam0-replay] [INF] [ALL] Above message repeats 2 times [1:ml1:Cam0-replay] [INF] [ALL] [Mar 02 22:45:46] mlp_setupmode: Raw changes: 603 - changes after 'EedDl': 293 - labels: 2 - noise level: 11 [2:nc2:Cam0-replay] [INF] [NET] Above message repeats 3 times [2:nc2:Cam0-replay] [INF] [NET] [Mar 02 22:45:46] netcam_rtsp_read_image: Normal resolution: service: file, av_read_frame: End of file, Interrupt: False [2:nc2:Cam0-replay] [ERR] [NET] [Mar 02 22:45:46] netcam_rtsp_read_image: "End of file" file:// stream detected, process completed, shutdown [2:nc2:Cam0-replay] [INF] [NET] [Mar 02 22:45:46] netcam_rtsp_handler: Normal resolution: Handler loop finished. [2:nc2:Cam0-replay] [INF] [NET] [Mar 02 22:45:46] netcam_rtsp_handler: netcam camera handler: finish set, exiting [1:ml1:Cam0-replay] [INF] [ALL] [Mar 02 22:45:46] mlp_setupmode: Raw changes: 603 - changes after 'EedDl': 293 - labels: 2 - noise level: 11 [1:ml1:Cam0-replay] [INF] [ALL] [Mar 02 22:45:46] mlp_setupmode: Raw changes: 418 - changes after 'EedDl': 293 - labels: 2 - noise level: 11 rd@master:~/tmp.nobackup/git/motion$ git diff diff --git a/src/netcam_rtsp.c b/src/netcam_rtsp.c index 63ac614..2de1d8f 100644 --- a/src/netcam_rtsp.c +++ b/src/netcam_rtsp.c @@ -616,9 +616,17 @@ static int netcam_rtsp_read_image(struct rtsp_context *rtsp_data){ if ((rtsp_data->interrupted) || (retcd < 0)) { av_strerror(retcd, errstr, sizeof(errstr)); MOTION_LOG(INF, TYPE_NETCAM, NO_ERRNO - ,_("%s: av_read_frame: %s ,Interrupt: %s") - ,rtsp_data->cameratype + ,_("%s: service: %s, av_read_frame: %s, Interrupt: %s") + ,rtsp_data->cameratype, rtsp_data->service ,errstr, rtsp_data->interrupted ? _("True"):_("False")); + // if processing of file:// completed - shutdown motion + + if (!strcmp(rtsp_data->service, "file") && !strcmp(errstr, "End of file")) { + MOTION_LOG(ERR, TYPE_NETCAM, NO_ERRNO, "\"%s\" file:// stream detected, process completed, shutdown", errstr); + rtsp_data->status = RTSP_NOTCONNECTED; + rtsp_data->finish = TRUE; + } + my_packet_unref(rtsp_data->packet_recv); netcam_rtsp_close_context(rtsp_data); return -1; rd@master:~/tmp.nobackup/git/motion$ Thanks Rainer Am Montag, 2. März 2020, 10:08:42 CET schrieb tosiara:

…

Check this path: ``` diff --git a/src/netcam_rtsp.c b/src/netcam_rtsp.c index 63ac614..2de1d8f 100644 --- a/src/netcam_rtsp.c +++ b/src/netcam_rtsp.c @@ -616,9 +616,17 @@ static int netcam_rtsp_read_image(struct rtsp_context *rtsp_data){ if ((rtsp_data->interrupted) || (retcd < 0)) { av_strerror(retcd, errstr, sizeof(errstr)); MOTION_LOG(INF, TYPE_NETCAM, NO_ERRNO - ,_("%s: av_read_frame: %s ,Interrupt: %s") - ,rtsp_data->cameratype + ,_("%s: service: %s, av_read_frame: %s, Interrupt: %s") + ,rtsp_data->cameratype, rtsp_data->service ,errstr, rtsp_data->interrupted ? _("True"):_("False")); + // if processing of file:// completed - shutdown motion + + if (!strcmp(rtsp_data->service, "file") && !strcmp(errstr, "End of file")) { + MOTION_LOG(ERR, TYPE_NETCAM, NO_ERRNO, "\"%s\" file:// stream detected, process completed, shutdown", errstr); + rtsp_data->status = RTSP_NOTCONNECTED; + rtsp_data->finish = TRUE; + } + my_packet_unref(rtsp_data->packet_recv); netcam_rtsp_close_context(rtsp_data); return -1; ``` For some reason I cannot force my motion to exit. It finishes reading file, but keeps running for some reason

-- Rainer Dorsch http://bokomoko.de/

0 replies

tosiara · 2020-03-03T05:51:26Z

tosiara
Mar 3, 2020
Maintainer Author

Yeah, that's what I see too. The thread exits, but motion keeps running. We need to find a better way to exit motion from within the rtsp code

0 replies

rdorsch · 2020-04-13T13:07:01Z

rdorsch
Apr 13, 2020

Hi tosiara,

I came back to this issue now and digged a bit into it. For me it is fixed if I set the context to finish not the rtsp context only (actually, I do not see a difference if I set rtsp context to finish or not):


rd@master:~/tmp.nobackup/git/motion$ git diff
diff --git a/src/netcam_rtsp.c b/src/netcam_rtsp.c
index 63ac614..a2187e2 100644
--- a/src/netcam_rtsp.c
+++ b/src/netcam_rtsp.c
@@ -616,9 +616,18 @@ static int netcam_rtsp_read_image(struct rtsp_context *rtsp_data){
         if ((rtsp_data->interrupted) || (retcd < 0)) {
             av_strerror(retcd, errstr, sizeof(errstr));
             MOTION_LOG(INF, TYPE_NETCAM, NO_ERRNO
-                ,_("%s: av_read_frame: %s ,Interrupt: %s")
-                ,rtsp_data->cameratype
+                ,_("%s: service: %s, av_read_frame: %s, Interrupt: %s")
+                ,rtsp_data->cameratype, rtsp_data->service
                 ,errstr, rtsp_data->interrupted ? _("True"):_("False"));
+            // if processing of file:// completed - shutdown motion
+
+            if (!strcmp(rtsp_data->service, "file") && !strcmp(errstr, "End of file")) {
+                MOTION_LOG(ERR, TYPE_NETCAM, NO_ERRNO, "\"%s\" file:// stream detected, process completed, shutdown", errstr);
+                rtsp_data->status = RTSP_NOTCONNECTED;
+                rtsp_data->finish = TRUE;
+                rtsp_data->cnt->finish = TRUE;
+            }
+
             my_packet_unref(rtsp_data->packet_recv);
             netcam_rtsp_close_context(rtsp_data);
             return -1;
rd@master:~/tmp.nobackup/git/motion$

I have to admit that I have at best a partial understanding of the code, so the change should be reviewed by somebody more knowledgeable.

0 replies

JacquesBB · 2020-05-23T14:29:39Z

JacquesBB
May 23, 2020

Dear All,

I encounter the same problem. Endless loop when processing a file.
I would very much appreciate that this issue is solved as I need to process hundreds of files.

Below is the output for two pass over the same file, with the creation of two identical output.
motion was stopped with ^C.

[1:ml1] [NTC] [ALL] motion_init: Camera 0 started: motion detection Enabled
[1:ml1] [NTC] [VID] vid_start: Opening Netcam RTSP
[1:ml1] [INF] [NET] netcam_rtsp_set_parms: Setting up Normal resolution stream.
[1:ml1] [INF] [NET] netcam_url_parse: Using port number 0
[1:ml1] [INF] [NET] netcam_rtsp_set_path: Setting up file via ffmpeg netcam
[1:ml1] [INF] [NET] netcam_rtsp_set_file: Normal resolution: Setting attributes to read file
[1:ml1] [INF] [NET] netcam_rtsp_open_context: Normal resolution: Opened camera((null))
[1:ml1] [INF] [ENC] ffmpeg_avcodec_log: Stream #0: not enough frames to estimate rate; consider increasing probesize
[1:ml1] [DBG] [NET] netcam_check_buffsize: expanding buffer from [0/0] to [0/3112960] bytes.
[1:ml1] [DBG] [NET] Above message repeats 1 times
[1:ml1] [DBG] [NET] netcam_check_buffsize: expanding buffer from [3110400/3112960] to [3110400/6221824] bytes.
[1:ml1] [NTC] [NET] netcam_rtsp_connect: Normal resolution: Camera ((null)) connected
[1:ml1] [DBG] [NET] netcam_check_buffsize: expanding buffer from [3110400/3112960] to [3110400/6221824] bytes.
[1:ml1] [CRT] [NET] motion_init: Substream not available. Image sizes not modulo 16.
[1:ml1] [NTC] [ALL] image_ring_resize: Resizing pre_capture buffer to 1 items
[2:nc2] [NTC] [NET] netcam_rtsp_handler: Normal resolution: Camera handler thread [2] started
[2:nc2] [INF] [NET] netcam_rtsp_set_file: Normal resolution: Setting attributes to read file
[2:nc2] [INF] [NET] netcam_rtsp_open_context: Normal resolution: Opened camera((null))
[2:nc2] [INF] [ENC] ffmpeg_avcodec_log: Stream #0: not enough frames to estimate rate; consider increasing probesize
[2:nc2] [NTC] [NET] netcam_rtsp_connect: Normal resolution: Camera ((null)) connected
[1:ml1] [NTC] [ALL] image_ring_resize: Resizing pre_capture buffer to 15 items
[1:ml1] [INF] [EVT] event_new_video: Source FPS 23
[1:ml1] [INF] [ENC] ffmpeg_set_quality: libx264 codec vbr/crf/bit_rate: 0
[1:ml1] [NTC] [EVT] event_newfile: File of type 8 saved to: DATA/FILMS/0-01-20200523160553.mkv
[1:ml1] [NTC] [ALL] motion_detected: Motion detected - starting event 1
[2:nc2] [INF] [NET] netcam_rtsp_read_image: Normal resolution: av_read_frame: End of file ,Interrupt: False
[2:nc2] [ERR] [NET] netcam_rtsp_handler_reconnect: Normal resolution: Reconnecting with camera....
[2:nc2] [INF] [NET] netcam_rtsp_set_file: Normal resolution: Setting attributes to read file
[2:nc2] [INF] [NET] netcam_rtsp_open_context: Normal resolution: Opened camera((null))
[2:nc2] [INF] [ENC] ffmpeg_avcodec_log: Stream #0: not enough frames to estimate rate; consider increasing probesize
[2:nc2] [NTC] [NET] netcam_rtsp_connect: Normal resolution: Camera ((null)) connected
[1:ml1] [NTC] [ALL] mlp_actions: End of event 1
[1:ml1] [INF] [EVT] event_new_video: Source FPS 24
[1:ml1] [INF] [ENC] ffmpeg_set_quality: libx264 codec vbr/crf/bit_rate: 0
[1:ml1] [NTC] [EVT] event_newfile: File of type 8 saved to: DATA/FILMS/0-02-20200523161834.mkv
[1:ml1] [NTC] [ALL] motion_detected: Motion detected - starting event 2
[2:nc2] [INF] [NET] netcam_rtsp_read_image: Normal resolution: av_read_frame: End of file ,Interrupt: False
[2:nc2] [ERR] [NET] netcam_rtsp_handler_reconnect: Normal resolution: Reconnecting with camera....
[2:nc2] [INF] [NET] netcam_rtsp_set_file: Normal resolution: Setting attributes to read file
[2:nc2] [INF] [NET] netcam_rtsp_open_context: Normal resolution: Opened camera((null))
[2:nc2] [INF] [ENC] ffmpeg_avcodec_log: Stream #0: not enough frames to estimate rate; consider increasing probesize
[2:nc2] [NTC] [NET] netcam_rtsp_connect: Normal resolution: Camera ((null)) connected
[1:ml1] [NTC] [ALL] mlp_actions: End of event 2

0 replies

JacquesBB · 2020-05-23T22:09:55Z

JacquesBB
May 23, 2020

To get around this problem, I have added to my crontab this script that I run every minute when I am using motion. I am sure someone has a better idea.

#!/bin/bash
DIR=/Users/jxl/jxlmotion
echo $DIR
cd $DIR
a=cat motion.log | grep ERR | grep netcam_rtsp_handler_reconnect | wc| awk '{print $1}'
echo $a
if [ $a -gt 0 ]
then
echo $a kill
pid=ps aux | grep motion | grep -v grep| awk '{print $2}'
echo $pid
kill -9 $pid
echo 0 > motion.run
fi

0 replies

tosiara · 2022-01-26T07:54:29Z

tosiara
Jan 26, 2022
Maintainer Author

The proposed patch #1122 (comment) no longer works. In the latest version it only cases motion to restart, not quit:

[2:nc2:motion] [ERR] [NET] netcam_rtsp_read_image: "End of file" file:// stream detected, process completed, shutdown
[2:nc2:motion] [INF] [NET] netcam_rtsp_handler: norm: Handler loop finished.
[1:ml1:motion] [NTC] [ALL] motion_loop: Thread exiting
[1:ml1:motion] [NTC] [EVT] event_extpipe_end: CLOSING: extpipe file desc 10, error state 0
[1:ml1:motion] [NTC] [EVT] event_extpipe_end: pclose return: -1
[1:ml1:motion] [DBG] [EVT] event_closefile: Saved movie to file: /tmp/02-20220126-0945
[1:ml1:motion] [INF] [ALL] motion_cleanup: Calling vid_close() from motion_cleanup
[1:ml1:motion] [INF] [VID] vid_close: calling netcam_rtsp_cleanup
[1:ml1:motion] [INF] [NET] netcam_rtsp_cleanup: norm: Shutting down network camera.
[2:nc2:motion] [INF] [NET] netcam_rtsp_handler: netcam camera handler: finish set, exiting
[1:ml1:motion] [NTC] [NET] netcam_rtsp_cleanup: Normal resolution: Shut down complete.
[0:motion] [NTC] [ALL] main: Motion thread 1 restart

0 replies

tosiara · 2022-01-26T08:16:59Z

tosiara
Jan 26, 2022
Maintainer Author

This seems to work:

diff --git a/src/netcam_rtsp.c b/src/netcam_rtsp.c
index 51efcd9..7ce869c 100644
--- a/src/netcam_rtsp.c
+++ b/src/netcam_rtsp.c
@@ -1179,6 +1179,12 @@ static int netcam_rtsp_read_image(struct rtsp_context *rtsp_data)
                 MOTION_LOG(INF, TYPE_NETCAM, NO_ERRNO
                     ,_("%s: av_read_frame: %s")
                     ,rtsp_data->cameratype, errstr);
+
+                if (!strcmp(rtsp_data->service, "file") && !strcmp(errstr, "End of file")) {
+                    MOTION_LOG(ERR, TYPE_NETCAM, NO_ERRNO, "\"%s\" file:// stream detected, process completed, shutdown", errstr);
+                    rtsp_data->finish = TRUE;
+                    rtsp_data->status = RTSP_NOTCONNECTED;
+                }
             } else {
                 MOTION_LOG(INF, TYPE_NETCAM, NO_ERRNO
                     ,_("%s: Excessive tries to get data from camera %d")

But because of the current issue #1461 motion does not fully exit:

[2:nc2:motion] [INF] [NET] netcam_rtsp_read_image: norm: av_read_frame: End of file
[2:nc2:motion] [ERR] [NET] netcam_rtsp_read_image: "End of file" file:// stream detected, process completed, shutdown
[2:nc2:motion] [INF] [NET] netcam_rtsp_handler: norm: Handler loop finished.
[2:nc2:motion] [INF] [NET] netcam_rtsp_handler: netcam camera handler: finish set, exiting
[1:ml1:motion] [NTC] [EVT] event_newfile: Writing image to file: /tmp/02-20220126-1014.jpg
[1:ml1:motion] [NTC] [EVT] event_extpipe_end: CLOSING: extpipe file desc 10, error state 0
                                                                               
encoded 377 frames, 48.20 fps, 6543.20 kb/s             
[1:ml1:motion] [NTC] [EVT] event_extpipe_end: pclose return: -1
[1:ml1:motion] [DBG] [EVT] event_closefile: Saved movie to file: /tmp/02-20220126-1014
[1:ml1:motion] [NTC] [ALL] mlp_actions: End of event 2
[1:ml1:motion] [NTC] [ALL] mlp_capture: Video signal lost - Adding grey image
(hangs here forever)

0 replies

Mr-Dave · 2022-01-26T13:39:16Z

Mr-Dave
Jan 26, 2022
Maintainer

I do not believe it would be correct to shutdown after it reaches the end. The looping is exactly what was intended so that parameters can be tuned and evaluated.

1 reply

combs Sep 14, 2023

Another use case—which might be an edge case—-is to run motion on a recording from another system (such as an offline camera) as a one-time processing step. In this case, file:// urls are not used to tune or evaluate parameters.

My take, as a rando who is grateful for your work on this software, is that a configuration option for the "loop forever" behavior would be useful. Thank you for your consideration.

tosiara · 2022-01-27T06:08:06Z

tosiara
Jan 27, 2022
Maintainer Author

As you can see, there were at least three users who were confused about it. Do you think it is worth to add a configuration param that would control this behavior or we should keep all as is?

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shutdown motion when file:// reached EOF #1501

{{title}}

Replies: 11 comments 1 reply

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

Shutdown motion when file:// reached EOF #1501

tosiara Feb 28, 2020 Maintainer

Replies: 11 comments · 1 reply

rdorsch Feb 29, 2020

tosiara Mar 2, 2020 Maintainer Author

rdorsch Mar 2, 2020

tosiara Mar 3, 2020 Maintainer Author

rdorsch Apr 13, 2020

JacquesBB May 23, 2020

JacquesBB May 23, 2020

tosiara Jan 26, 2022 Maintainer Author

tosiara Jan 26, 2022 Maintainer Author

Mr-Dave Jan 26, 2022 Maintainer

combs Sep 14, 2023

tosiara Jan 27, 2022 Maintainer Author

tosiara
Feb 28, 2020
Maintainer

Replies: 11 comments 1 reply

rdorsch
Feb 29, 2020

tosiara
Mar 2, 2020
Maintainer Author

rdorsch
Mar 2, 2020

tosiara
Mar 3, 2020
Maintainer Author

rdorsch
Apr 13, 2020

JacquesBB
May 23, 2020

JacquesBB
May 23, 2020

tosiara
Jan 26, 2022
Maintainer Author

tosiara
Jan 26, 2022
Maintainer Author

Mr-Dave
Jan 26, 2022
Maintainer

tosiara
Jan 27, 2022
Maintainer Author