Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using with Typescript #570

Open
bsurai opened this issue Jul 3, 2017 · 10 comments
Open

Using with Typescript #570

bsurai opened this issue Jul 3, 2017 · 10 comments

Comments

@bsurai
Copy link
Contributor

bsurai commented Jul 3, 2017

Hi.
I'd like to use virtual-keyboard with typescript. Do you have a typescript definition file/package?

@Mottie
Copy link
Owner

Mottie commented Jul 3, 2017

Hi @bsurai!

This was mentioned in #502, but I haven't written anything in Typescript so I am not sure what a definition file/package would need to include.

I am in the process of rewriting this plugin using pure JS - see #559. If you would like to help contribute, let me know.

@bsurai
Copy link
Contributor Author

bsurai commented Jul 3, 2017

Perhaps, I will have to do it. I will let you know, when I will have result.

@bsurai
Copy link
Contributor Author

bsurai commented Jul 5, 2017

@Mottie. I've got some result. Here is .zip with type definition file and example how to use it in typescript. It was enough for me at the moment.
typings.zip

@Mottie
Copy link
Owner

Mottie commented Jul 5, 2017

Awesome! Thank you for sharing. I'll take a look, but would you be willing to set up a repository for that code with your example? Or would you rather submit a PR, and I'll add you as a contributor so you can help me maintain it?

@bsurai
Copy link
Contributor Author

bsurai commented Jul 5, 2017

Ok. I will.

@bsurai
Copy link
Contributor Author

bsurai commented Jul 19, 2017

Hi @Mottie. What folder can I use for typescript example?

@Mottie
Copy link
Owner

Mottie commented Jul 19, 2017

It is a working example? Either way, you can add it to the docs folder... if it isn't a working example, then add a block showing the code. I can update the index page if you don't want to deal with that part of it.

@bsurai
Copy link
Contributor Author

bsurai commented Jul 19, 2017

I have a new working example with some changes.

@bsurai
Copy link
Contributor Author

bsurai commented Aug 9, 2017

I did something better. There is public definition with example and instruction. It was checked and accepted by http://definitelytyped.org/.
https://www.npmjs.com/package/@types/virtual-keyboard
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/virtual-keyboard

@Mottie
Copy link
Owner

Mottie commented Aug 9, 2017

Awesome!

Would you please update the readme:

  • Typescript badge.
  • A snippet under "Installation" on how to use it... it's npm install --save-dev @types/virtual-keyboard, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants