Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential OOM bug/exploit in graphite NBT #8

Open
rj00a opened this issue Sep 22, 2022 · 1 comment
Open

Potential OOM bug/exploit in graphite NBT #8

rj00a opened this issue Sep 22, 2022 · 1 comment

Comments

@rj00a
Copy link
Contributor

rj00a commented Sep 22, 2022

In crates/graphite_binary/src/nbt/decode.rs the read_list function uses Vec::with_capacity(length as _). However, length has no upper bound. I believe malicious input could potentially allocate i32::MAX * sizeof(usize) bytes.

The other read functions are correctly bounded.
@Moulberry
Copy link
Owner

Should be fixed by aca938b, will leave issue open until confirmation from a second person

@Moulberry Moulberry reopened this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Moulberry @rj00a