Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI won't start because of import errors #51

Open
1 of 3 tasks
shashwatsridhar opened this issue Dec 8, 2020 · 0 comments · Fixed by #52
Open
1 of 3 tasks

GUI won't start because of import errors #51

shashwatsridhar opened this issue Dec 8, 2020 · 0 comments · Fixed by #52
Assignees

Comments

@shashwatsridhar
Copy link
Collaborator

shashwatsridhar commented Dec 8, 2020

After the recent merge of a pull request, the GUI fails to load due to an import error. The issue is in the order of imports in the gui/__init__.py file, wherein all the individual widgets of the GUI should be imported before the main class KiloSortGUI and the launcher function launcher.

This also points to the need for tests for the GUI, so that such issues don't arise in the future.

Thus, immediate todo:

  • fix import error

Further goals

  • Setup tests for the GUI which check for basic functionality - does the GUI load, does the GUI close uneventfully? (smoke tests)
  • Add tests which mimic GUI interactions using such tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant