Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you seen VS 2015 Roslyn tooltips? #30

Closed
dsaf opened this issue Feb 20, 2015 · 4 comments
Closed

Have you seen VS 2015 Roslyn tooltips? #30

dsaf opened this issue Feb 20, 2015 · 4 comments

Comments

@dsaf
Copy link
Contributor

dsaf commented Feb 20, 2015

It seems to be quite close to ET (R# 8.2.3) and while lacking important features has some interesting ones:

  1. on constants they are also showing the constant's value;
  2. they are omitting the full namespace on members;
  3. extension methods are shown as "(extension)" not "(method)".
  4. displaying info about operators (they are more like methods than keywords afterall);
  5. "optional.Value.HasValue" is displayed as "double?.HasValue" not like "System.Nullable.HasValue" - is this C#6 specific?

In my opinion all of the above would be a great addition to ET.

@MrJul
Copy link
Owner

MrJul commented Feb 20, 2015

  1. ReSharper does too. ET does not: it should definitely be changed.
  2. Not sure about this by default, could be an option IMO. Same thing with containing classes for nested classes, modifiers or constant values.
  3. Easy and helpful change, will do.
  4. Already done as a side effect of Are some standard primitive types still using the default tooltip? #17.
  5. It's not C# 6 specific, VS2013 already displays Nullable<T>.Value as T?.Value. I find it weird as a member path, but that's completely subjective. ET mimics ReSharper here and doesn't use type keywords to refer to a member's type. Another option?

@dsaf dsaf changed the title [discussion] Have you seen VS 2015 Roslyn tooltips? Have you seen VS 2015 Roslyn tooltips? Feb 20, 2015
@dsaf
Copy link
Contributor Author

dsaf commented Feb 20, 2015

  1. option is good;
  2. I don't know now :). In C#6 and its null propagation I might get slightly confused whether I am looking at a null-safe code handling a POCO that happens to have a Value property or an actual Nullable:
public class FormulaEntry
{
   public double? Value { get; set; }
}
...
public void SafelyPrint(FormulaEntry entry)
{
   Console.WriteLine(entry?.Value.Value);
}

PS: Actually it's not that bad - option would be good I guess...

@MrJul
Copy link
Owner

MrJul commented Feb 20, 2015

  1. and 3) fixed on f1aa2fe

This was referenced Aug 3, 2015
@MrJul
Copy link
Owner

MrJul commented Aug 3, 2015

1, 3, 4 are fixed.
2 is #51
5 is #52

@MrJul MrJul closed this as completed Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants