Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return function hashes #3

Open
jebonfig opened this issue Apr 12, 2019 · 1 comment
Open

Return function hashes #3

jebonfig opened this issue Apr 12, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@jebonfig
Copy link

From what I understand, the evm.getFunctions() call only returns functions that appear in the functionHashes.json lookup. If the hash is not mapped in this file, it won't be returned.

Assuming the code is able to distinguish and parse out function hashes contained in a contract's bytecode without using the mapping file, could we add a function to return all function hashes in a contract? Maybe something like getFunctionHashes(): which returns `{'functionHash': 'functionSignature'}? (functionSignature would be null if couldn't be mapped)

If the mapping lookup is necessary for extracting the functions, how about adding an optional parameter to evm.getFunctions() for additional function hash -> signature mappings to check for in addition to the mapping file?

@MrLuit MrLuit added the enhancement New feature or request label May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@jebonfig @MrLuit and others