Firefox 133: "hide_tabs_toolbar" and "windows_control_placeholder_support" Not Displaying Minimize, Maximize, and Close Buttons

[supervaka]

EDIT: Resolved after reading #467 (comment), but I guess I'll keep this issue for posterity.
Can this be documented either in the readme or hide_tabs_toolbar.css + windows_control_placeholder_support.css?

.
.
.
Similar but different compared to #474
I did not touch widget.windows.mica (so it is false).
And I use v1, not hide_tabs_toolbar_v2.css

my userChrome.css(git pull'd 10 minutes ago):

@import url(chrome/window_control_placeholder_support.css);
@import url(chrome/hide_tabs_toolbar.css);

Nothing happens when I click on the empty space where the maximize, minimize and close buttons used to be

As mentioned in #474 when I set sidebar.revamp and sidebar.verticalTabs to true I see this:

The buttons on the left change on hover and are functional
The buttons on the right do not change on hover, and they are not functional

I'm on Windows 11 using Firefox 133
Would it be useful to share my prefs.js? or any thing else?

[MrOtherGuy]

Yeah, considering the number of issues created about this I think it might be worth it to add a note to the old styles.

I kinda hoped I could handle this such that when ESR 128 cycle is over I would migrate "_v2" styles to the original file names. Alternatively I could migrate them right now and just rust move the original old files to deprecated folder. But I don't know how best to handle this honestly.

[Yasand123]

How are we supposed to fix this as users for now? I can't seem to find window_control_placeholder_support_v2.

Edit: it seems using the new hide_tabs_toolbar_v2 by itself is enough. window_control_placeholder_support is not needed.

[MrOtherGuy]

Yes, window_control_placeholder_support.css only exisits for users of ESR 128 - otherwise I'd move it to deprecated.

[plissken1138]

I was using windows_control_placeholder_support.css and tabs_on_bottom_v2.css in Developer and it just lost the windows control buttons after 135.0b1 update. I tried hide_tabs_toolbar_v2 and it does restore windows control buttons but it obviously hides tabs.

How can I restore window controls and retain tabs on bottom?

(Oddly enough, windows_control_placeholder_support.css still works in regular Firefox 134.0 at my end)

EDIT: ah, updated tabs_on_bottom_v2.css and it worked!
Seems I tinekered with at some point it and forgot, then it messed up the whole thing without windows_control_placeholder_support.css

[trallnag]

For me the windows controls are disappearing even with hide_tabs_toolbar_v2 and I am on Firefox 135 right now. Weird. My config is pretty small.

@import url(chrome/bookmark_panel_enlarge.css);
@import url(chrome/hide_tabs_toolbar_v2.css);

/*
Decrease size of the sidebar header.
*/

#sidebar-header {
  font-size: 1.2em !important;
  padding: 2px 6px 2px 3px !important;
}
#sidebar-header #sidebar-close {
  padding: 3px !important;
}
#sidebar-header #sidebar-close .toolbarbutton-icon {
  width: 14px !important;
  height: 14px !important;
  opacity: 0.6 !important;
}

/*
Decrease padding of bookmark menu items.

Based on: https://support.mozilla.org/en-US/questions/1337842
*/


menupopup:not(.in-menulist) > menuitem,
menupopup:not(.in-menulist) > menu {
  padding-block: 2px !important;
}
:root {
  --arrowpanel-menuitem-padding: 4px 8px !important;
}

[MrOtherGuy]

@trallnag what OS do you have? Also, could you confirm that your copy of hide_tabs_toolbar_v2 is up-to-date with the repository?

[trallnag]

@MrOtherGuy, my bad. In my fork of this repo in the past I patched the CSS so that the tab bar only disappears when Sidebery is activated based on a tab title prefix.

94a7b9e

Seems like it is just my patch that is not working anymore.