Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autohide_bookmarks_and_main_toolbars results in unexpected vertical spacing #517

Open
actforjason opened this issue Feb 22, 2025 · 6 comments

Comments

@actforjason
Copy link

There is a space between the main toolbar and the bookmarks bar.
27 " 2k screen
Image

@actforjason actforjason changed the title 'autohide_bookmarks_and_main_toolbars' results in unexpected vertical spacing autohide_bookmarks_and_main_toolbars results in unexpected vertical spacing Feb 22, 2025
@MrOtherGuy
Copy link
Owner

Can you tell me what display scaling you use? Also, what OS do you have, and do you have any other styles applied?
It's also quite possible that this is caused by non-latin font which could be making have unexpected height and thus leave a space there. We kind of have to use to fixed inset values unfortunately, and unexpected height for toolbars will then have this kind of problems.

@actforjason
Copy link
Author

actforjason commented Feb 22, 2025

124% scaling on Windows 11. I remember that there was no problem with 125% scaling before.

@actforjason
Copy link
Author

actforjason commented Feb 23, 2025

124% scaling on Windows 11. I remember that there was no problem with 125% scaling before.

The same problem with 125% scaling. The same configuration previously seemed to be fine.

@MrOtherGuy
Copy link
Owner

But do you have any other custom styles applied? I'm unable to reproduce this issue on Windows 10 with 100% or 125% scaling neither with normal or compact density - kinda looks like you might be using compact mode, is that right?

Could you try if this issue occurs with 100% scaling?

@MrOtherGuy
Copy link
Owner

I've added some scaling dependent styling for that style, so see how that works out. I fixed the behavior in scenarios I could reproduce, but this issue feels like it's probable very system or Firefox setup specific so it might not improve anything on your system. But hopefully it doesn't make anything worse at least.

@actforjason
Copy link
Author

There are still problems
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants