Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review #1

Open
matthdsm opened this issue Jun 16, 2021 · 4 comments
Open

Code review #1

matthdsm opened this issue Jun 16, 2021 · 4 comments

Comments

@matthdsm
Copy link
Collaborator

/remind me to bother @ewels in november
@matthdsm
Copy link
Collaborator Author

Hi @ewels ,

You asked me to bother you in November, but since it's already Januari here's a small poke.

Cheers
Matthias

@ewels
Copy link
Member

ewels commented Jan 28, 2022

Excellent! What was it that I asked you to bother me about..? 🤔

@matthdsm
Copy link
Collaborator Author

Good question! Going off the title, I suppose it was a general code/functionality review. We've run the plugin since June without a hitch (except a small issue I've just noticed, see #2 ), but there's always room for improvement.

Thanks
Matthias

@ewels
Copy link
Member

ewels commented Jan 28, 2022

Glad it's not just me that doesn't remember 😆 Yeah I think you're right: MultiQC/MultiQC#1431 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewels @matthdsm