-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename a Portal #616
Comments
This should actually not be very difficult to do at all. If someone forked the codebase, I think this could be done in about an hour. You can actually probably do it with a text editor, too. For example, suppose you want to change portal TreetopRestStop to OakTreetopRestStop. Load portals.yml into vim, and do something like %s/TreetopRestStop/OakTreetopRestStop/g (basically, a string find and replace). You'll also want to make sure the world is correct too. So, you'd first want to change the portal itself, e.g. TreetopRestStop: and then you'd want to change all references to that portal, e.g. test: Like I mentioned, forking the codebase and implementing it would be almost trivial, and I'd recommend it since your idea is a good one, and it appears nobody is willing to implement it. However, doing it with a text editor seems so trivial, it seems a shame to waste time implementing. Maybe that's why nobody's picked it up? |
I will probably get around it eventually, but mv isn't the only project I have. Since you said it's quite easy, why not you open a PR 😛? Always happy to see good contributions. |
I would, but I don't know if you want me touching your code. I'm a C++/python guy who moonlights as a Java dev. LOL. Edit: Wow! Your code is super clean and a pleasure to learn from. I'm normally used to Bukkit plugins looking like spaghetti run through a blender and squished by a steamroller. |
Doesn't hurt to try. And lol. |
As the title states, add ability to rename an mv-portal.
The text was updated successfully, but these errors were encountered: