Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umd build does not work in browser #67

Open
wangzuo opened this issue Jun 13, 2018 · 5 comments
Open

umd build does not work in browser #67

wangzuo opened this issue Jun 13, 2018 · 5 comments

Comments

@wangzuo
Copy link

wangzuo commented Jun 13, 2018

The current dist bundle does not include any external modules. Any plan to support this module as a standalone library? I really like the provider design of this library and can help with this.

Thank you.

@wangzuo wangzuo closed this as completed Jun 15, 2018
@HenryNguyen5 HenryNguyen5 reopened this Jun 15, 2018
@HenryNguyen5
Copy link
Contributor

Hi @wangzuo, any reason for closing this issue? I'd be happy to help provide / collaborate solutions for this. We never had a need to package the external modules with the bundle since we use Webpack on our browser build to provide the needed modules.

@wangzuo
Copy link
Author

wangzuo commented Jun 19, 2018

Here is my attempt to add the browser build: master...wangzuo:webpack-build. There is still some work to reduce the bundle size and add test case.

@HenryNguyen5
Copy link
Contributor

HenryNguyen5 commented Jun 20, 2018

Nice! I'm hoping that this does not break builds that expect it to not have any external dependencies bundled though. But as far as I can see, it shouldn't as our Webpack build for the site should be pulling the .es6 version. Also, is webpack needed for this? Rollup might work still.

@wangzuo
Copy link
Author

wangzuo commented Jun 20, 2018

I think webpack is more straightforward here with built-in node libs support. Also it mighty also be helpful to export a minimal build of shepherd with only the network layer (no redux ...)..

@HenryNguyen5
Copy link
Contributor

It would be useful to have a comparison of bundle size of webpack vs rollup here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants