Skip to content

Commit 3b9f51a

Browse files
author
Benedikt Koeppel
committed
Removed all TODOs from source and added them to my mindmap
1 parent 704bc08 commit 3b9f51a

File tree

4 files changed

+0
-35
lines changed

4 files changed

+0
-35
lines changed

src/ch/benediktkoeppel/code/droidplane/HorizontalMindmapView.java

-1
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,6 @@ private NodeColumn getLeftmostVisibleColumn() {
481481
* Get the number of pixels that are visible on the leftmost column.
482482
* @return
483483
*/
484-
// TODO (medium): this is ugly, DRY from getLeftmostVisibleColumn() !
485484
private int getVisiblePixelOfLeftmostColumn() {
486485

487486
// how much we are horizontally scrolled

src/ch/benediktkoeppel/code/droidplane/MainActivity.java

-20
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,6 @@
2121

2222
import com.google.analytics.tracking.android.EasyTracker;
2323

24-
// TODO (low): think about a strategy to strip out Log.v and Log.d messages for releases
25-
// TODO (low): start using a SAX parser and build my own MindMap, dynamically build branches when user drills down, truncate branches when they are not used anymore. How will we do Edit Node / Insert Node, if we are using a SAX parser? Maybe we should not go for a SAX parser but find a more efficient DOM parser?
26-
27-
// TODO (low): allow us to open multiple files and display their root nodes and file names in the leftmost column.
28-
// TODO (medium): long-click on a root node shows a "close file" or "close this mindmap" menu
29-
// TODO (high): add a progress bar when opening a file (or a spinner or so)
30-
// TODO (low): can we get built-in icons as SVG?
31-
// TODO (medium): properly parse rich text nodes
32-
// TODO (high): implement OnItemLongClickListener with a context menu (show all icons, follow link, copy text, and ultimately also edit)
33-
3424
/**
3525
* The MainActivity can be started from the App Launcher, or with a File Open
3626
* intent. If the MainApplication was already running, the previously used
@@ -81,8 +71,6 @@ public void onCreate(Bundle savedInstanceState) {
8171
String type = intent.getType();
8272

8373
// if the application was reset, or the document has changed, we need to re-initialize everything
84-
// TODO (high): factor this stuff out. we really should have a loadDocument(InputStream) method somewhere
85-
8674
if ( application.mindmap == null || application.mindmap.document == null
8775
|| (application.mindmap.getUri()!=intent.getData() && intent.getData()!=null)
8876
|| (intent.getBooleanExtra(INTENT_START_HELP,false))
@@ -205,13 +193,6 @@ public void onCreate(Bundle savedInstanceState) {
205193
@Override
206194
public boolean onCreateOptionsMenu(android.view.Menu menu) {
207195

208-
// TODO (low): add "Find" button and menu -> should search underneath the
209-
// current node (or with an option, under the root node)
210-
211-
// TODO (medium): menu "Open"
212-
213-
// TODO (low): settings (to set the number of horizontal and vertical columns)
214-
215196
MenuInflater inflater = getMenuInflater();
216197
inflater.inflate(R.menu.main, menu);
217198
return true;
@@ -270,7 +251,6 @@ public boolean onOptionsItemSelected(android.view.MenuItem item) {
270251

271252

272253
// Handler when an item is long clicked
273-
// TODO (high): implement long-click handler
274254
// @Override
275255
// public boolean onItemLongClick(AdapterView<?> parent, View view, int position, long id) {
276256
//

src/ch/benediktkoeppel/code/droidplane/MainApplication.java

-12
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,6 @@
1313
@ReportsCrashes(formKey = "dE1VQVpQN2FNTWlLQXg1UUQ1b1VSN3c6MQ")
1414
public class MainApplication extends Application {
1515

16-
/*
17-
* TODO (high): some idiot (yes, me) thought that it was a very clever idea to
18-
* stuff everything into this application. However, now when we open
19-
* multiple documents (i.e. separate activities), then it all breaks
20-
* terribly. We'll have to see how we get all that stuff back into the
21-
* MainActivity.
22-
* But then again we have the problem when the screen rotates. What do we do
23-
* then? Or should we store everything in hashes here in the
24-
* MainApplication, and then give every MainActivity it's own variables back
25-
* out of this hash?
26-
*/
27-
2816
/**
2917
* Android Logging TAG
3018
*/

src/ch/benediktkoeppel/code/droidplane/MindmapNode.java

-2
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,9 @@ public MindmapNode(Node node) {
7272
this.node = node;
7373

7474
// extract the string (TEXT attribute) of the nodes
75-
// TODO (medium): how do we handle rich text nodes?
7675
text = tmp_element.getAttribute("TEXT");
7776

7877
// extract icons
79-
// TODO (low): how do we handle multiple icons?
8078
ArrayList<String> icons = getIcons();
8179
String icon="";
8280
icon_res_id = 0;

0 commit comments

Comments
 (0)