Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass array argument for SpaceAfterListArgumentSeparator in OutputFormat::createPretty() #878

Closed
JakeQZ opened this issue Feb 5, 2025 · 0 comments
Closed

Don't pass array argument for SpaceAfterListArgumentSeparator in OutputFormat::createPretty() #878

JakeQZ opened this issue Feb 5, 2025 · 0 comments
Labels
blocked Needs another issue to be resolved first cleanup deprecation A method, property, or some functionality has been deprecated.
Milestone
9.0.0: Drop suppo...

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Feb 5, 2025

As of #876, this will be deprecated.
@JakeQZ JakeQZ added cleanup deprecation A method, property, or some functionality has been deprecated. labels Feb 5, 2025
@JakeQZ JakeQZ added the blocked Needs another issue to be resolved first label Feb 5, 2025
JakeQZ added a commit that referenced this issue Feb 6, 2025
@JakeQZ
[CLEANUP] Add separate OutputFormat properties for arrays
4250c18 
`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

Resolves #866, #876, #878.
@JakeQZ JakeQZ mentioned this issue Feb 6, 2025
Merged
oliverklee pushed a commit that referenced this issue Feb 6, 2025
@JakeQZ
[CLEANUP] Add separate OutputFormat properties for arrays (#880)
7a12457 
`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

Resolves #866, #876, #878.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Needs another issue to be resolved first cleanup deprecation A method, property, or some functionality has been deprecated.
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

No branches or pull requests
2 participants
@oliverklee @JakeQZ