Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move our CI tools from Composer dev dependencies to PHARs via Phive #822

Closed
oliverklee opened this issue Dec 5, 2019 · 4 comments · Fixed by #975
Closed

Move our CI tools from Composer dev dependencies to PHARs via Phive #822

oliverklee opened this issue Dec 5, 2019 · 4 comments · Fixed by #975
Assignees

Comments

@oliverklee
Copy link
Contributor

The way https://github.com/sebastianbergmann/phpunit/ does it.

This will avoid problems with conflicting dependencies between the tools (or with the non-dev dependencies of Emogrifier itself).

@oliverklee
Copy link
Contributor Author

Comment by @burzum moved from #819 (comment):

@oliverklee how do you want to do the setup with Phive? Add the files in their according version to each branch / version? Or set it up when running Travis? I'm working on getting Phive set up only on Travis right now.

I've made some progress but it's trial and error with Travis... Is there no way to change the config online like we can do with Scrutinize and run builds using that config without committing the config file?

@oliverklee
Copy link
Contributor Author

how do you want to do the setup with Phive? Add the files in their according version to each branch / version? Or set it up when running Travis?

@burzum The way https://github.com/sebastianbergmann/phpunit/ does it, i.e., the usage via Phive should replace the current dev dependencies and should be available both for Travis CI as well as local development (via Composer scripts).

@oliverklee oliverklee self-assigned this Mar 28, 2020
oliverklee added a commit that referenced this issue Mar 28, 2020
This reduces conflicts between our dependencies.

Part of #822
oliverklee added a commit that referenced this issue Mar 28, 2020
This reduces conflicts between our dependencies.

Part of #822
JakeQZ pushed a commit that referenced this issue Mar 28, 2020
This reduces conflicts between our dependencies.

Part of #822
oliverklee added a commit that referenced this issue Mar 28, 2020
Also regenerate `phive.xml` to use the default formatting.

Part of #822
JakeQZ pushed a commit that referenced this issue Mar 28, 2020
Also regenerate `phive.xml` to use the default formatting.

Part of #822
oliverklee added a commit that referenced this issue Mar 29, 2020
@oliverklee
Copy link
Contributor Author

Note to myself: We can autoload from PHARs (e.g., so that Psalm can find PHPUnit's classes) this way: composer/composer#5036 (comment)

@oliverklee
Copy link
Contributor Author

And this is how to register an autoloader with Psalm:
https://psalm.dev/docs/running_psalm/configuration/#autoloader

oliverklee added a commit that referenced this issue Jun 14, 2020
oliverklee added a commit that referenced this issue Jun 14, 2020
JakeQZ pushed a commit that referenced this issue Jun 14, 2020
oliverklee added a commit that referenced this issue Jun 19, 2020
JakeQZ pushed a commit that referenced this issue Jun 20, 2020
oliverklee added a commit that referenced this issue Apr 6, 2021
This moves us one step further away from PHP dependency hell.

Closes #822
oliverklee added a commit that referenced this issue Apr 6, 2021
This moves us one step further away from PHP dependency hell.

Closes #822
JakeQZ pushed a commit that referenced this issue Apr 6, 2021
This moves us one step further away from PHP dependency hell.

Closes #822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant