Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lava in overworld #207

Open
SirStudMuffin opened this issue Jul 2, 2016 · 31 comments
Open

Lava in overworld #207

SirStudMuffin opened this issue Jul 2, 2016 · 31 comments

Comments

@SirStudMuffin
Copy link

SirStudMuffin commented Jul 2, 2016

http://imgur.com/Qw1cKHJ

@TheIcyOne
Copy link

Does it generate anywhere other than in ravines?

@SirStudMuffin
Copy link
Author

http://imgur.com/cvPpTga

@TheIcyOne
Copy link

Looks like all underground lava still generates, but nothing found above ground.

@Slind14
Copy link
Member

Slind14 commented Jul 2, 2016

can't be prevented with biome tweaker would need a custom mod unless one exists already

@TheIcyOne
Copy link

Lava doesn't generate in the nether, at least.

@Slind14
Copy link
Member

Slind14 commented Jul 2, 2016

hmm, I remember a discussion with the biome tweaks dev regarding the lava and that isn't possible with biome tweaker due to the way it generates. but that was more than half a year ago.

@drz2k
Copy link
Contributor

drz2k commented Jul 2, 2016

It would be very heavy (on the already heavy) worldgen to improve this. So i found a settings that was okay for me in terms of heavy worldgen and left lava blocks.
It works this way : BT checks for x times in each chunk if block xyz is lava, then replaces it. You COULD set this to something like 5.000.000 but the worlgend would become way too heavy.
Thoo the lava lake in the screenshot above looks a bit "much" compared to my original worldgen.

@TheIcyOne
Copy link

That looks like vanilla's underground lava generation, which should be cancellable using Forge's event bus system.

@johnfg2610 johnfg2610 added this to the 0.1.3 milestone Jul 3, 2016
@kindlich
Copy link
Contributor

kindlich commented Jul 4, 2016

Reika made a mod for changing cave and underground dungeon gen.

It was called "cave control"

https://sites.google.com/site/reikasminecraft/cave-control maybe we should add either this or an other mod if lava shoudnt spawn in the overworld it could also help with the mineshaft issue

@johnfg2610
Copy link
Contributor

how do we get hold of reika?

@Slind14
Copy link
Member

Slind14 commented Jul 4, 2016

might be worth doing a benchmark first, if it doubles worldgen time or even worse, probably best not to use it. @bookerthegeek is in contact with reika

@bookerthegeek
Copy link
Contributor

I can check biome tweaker, it should be doable. Cave control requires dragon API @Slind14 so I don't know if that would work. If it would it will work.

I'll check biome tweaker tonight.

@bookerthegeek
Copy link
Contributor

bookerthegeek commented Jul 5, 2016

Cave control works perfectly. Also solves #216

I'll go ask for perms if you want to use it. We can also use it to disable Dungeons and strongholds.

(This requires Dragon API..... so no cauldron unless someone can work a miracle.)

Before & After

Not benchmarked, but no noticeable difference in amount of time to start a singleplayer world.

@johnfg2610
Copy link
Contributor

Doesn't work with kcauldron?

@bookerthegeek
Copy link
Contributor

Not really. But we could add it anyways.

  • Client side won't matter as clients with it can connect to servers without it.
    • Will work for singleplayer games and gen the world correctly.
  • Server side, Worlds can be Generated on Forge, then disable the mod(s) after all the Pregen then switch the server to Cauldron.
    • We don't need it after the world is generated.

@Slind14
Copy link
Member

Slind14 commented Jul 5, 2016

MrWisski has been using Dragon API v14 on a cauldron server without issues, if it is only v15 and those features existed back in v14, we could use that.

@bookerthegeek
Copy link
Contributor

They exist on both. I'll go ask for permissions to include it in the pack.

@johnfg2610
Copy link
Contributor

thanks booker :)

@SirStudMuffin
Copy link
Author

Pi said he could do it with 3 lines of code

@bookerthegeek
Copy link
Contributor

True. But this will allow us the possibility of adding other mods such as expanded Redstone, and void monster. :)

I think I'll talk to Pi tonight about the three lines of code.

@johnfg2610
Copy link
Contributor

expanded Redstone is nice i was reading his what not to say section earlier so funny :P

@bookerthegeek
Copy link
Contributor

Right?

@johnfg2610
Copy link
Contributor

any update on getting perms?

@johnfg2610
Copy link
Contributor

https://sites.google.com/site/reikasminecraft/approved-modpacks im guessing we got perms then?

@tyler489
Copy link
Contributor

tyler489 commented Jul 8, 2016

Yeah. Ask if we can change recipys if we add a disclaimer tooltip

@johnfg2610
Copy link
Contributor

we only need cave control atm

@johnfg2610
Copy link
Contributor

where can we get version 14 from?

@knoxz
Copy link

knoxz commented Jul 10, 2016

you could use my mod and replace all the lava source blocks with blood or anything else. you would end up with close to no lava.
Cant retrogen that though ;-)

@tyler489
Copy link
Contributor

What mod @knoxz

@Bennyboy1695
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants