Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Volume' skill command being interpreted as a 'Brightness' intent #72

Closed
Olzeke51 opened this issue May 15, 2021 · 2 comments
Closed

'Volume' skill command being interpreted as a 'Brightness' intent #72

Olzeke51 opened this issue May 15, 2021 · 2 comments
Labels
bug Something isn't working Priority: High

Comments

@Olzeke51
Copy link

Describe the bug
system has been running since "2021-05-06 01:15:03.787" per the 'bus.log' [a long time for me]
system was basically useable ['news' & wakeword - excepted]
put unit to 'sleep' Fri night :: but 'woke' it Saturday and had issues with LED ring indications
troubleshooting the LEDs - ran into an issue with the 'Volume' skill

To Reproduce
Steps to reproduce the behavior:
long running on latest(s) ???
*
@11:19 ish UTC - played with volume switch [to see the LEDs] but no led-indication - volume did change !!

while it was timing out on a "what time is it" told it to "set volume to 50%" - RESponded with 'setting BRIGHTness to 50%"

checked the "https://github.com/mycroftai/skill-volume/tree/d6527214faf8797b06c8db7ca271f9884c4fa01f' and used it's example to set it to 7 --STILL got a 'brightness' response

Expected behavior
Volume skill to respond with the new setting it was commanded

Log files
mycroft-05-15_am_multiple.tar.gz

Environment (please complete the following information):

Device type: Mark2-Dev_kit , on network cable, uSDC
OS: default Ubuntu
Mycroft-core version: 20.08.1 -per Device setting @ home.mycroft account
Other versions: latest 05-13 02:22:00 on top of MarkII_arm-rpi64_Prod_005-stable_2021-04-08.img.gz
Additional context
have not changed any git-hub settings or manual configs (except web settings),
not on 'dev' afaik - unless it is part of a 'latest'

Chat channel response: [might provide a clue]
sgee_ 9:02 AM
the brightness/volume problem is likely to be found in the intent construction (here/here(Adapt->scattered))
a too loose intent tend to mix up things

@Olzeke51 Olzeke51 added the bug Something isn't working label May 15, 2021
@krisgesling
Copy link
Collaborator

Based on additional info in Chat, a bugfix for the volume intent not catching has been submitted:
MycroftAI/skill-volume#74

@krisgesling krisgesling added bug Something isn't working Priority: High and removed bug Something isn't working labels May 17, 2021
@Olzeke51
Copy link
Author

based on input for gez-mycroft - files were missing from the skill folder, reinstalled and volume now responds properly
His question (and mine) is how did those files come up missing - my suggestion was that part of the 'fix' for the missing '8' led/volume bug issue may have done an incomplete replacement.
'
i consider this issue closed - but the 'skill-volume#74 did catch an other issue with the STT engines
it would be hard to diagnose why my files were missing..........Gary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: High
Projects
None yet
Development

No branches or pull requests

2 participants