Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play Music" phrase not working as expected #18

Open
Deukhoofd opened this issue Feb 17, 2019 · 2 comments
Open

"Play Music" phrase not working as expected #18

Deukhoofd opened this issue Feb 17, 2019 · 2 comments

Comments

@Deukhoofd
Copy link

Expected behaviour would be that the music continues playing from pause. Unfortunately current behaviour is that it searches for a song or album containing "Music".

@pixelherodev
Copy link

You can use "resume", or "resume music".

My question here is whether "play music" should resume - or rather, whether it should only resume. Here's my idea of how this should be implemented:

IF A SKILL IS PAUSED:
    RESUME
ELSE
    SELECT FALLBACK MUSIC SKILL, START PLAYING

For instance, I could set Pandora as my default music skill, so if I say "Play music" and nothing is already playing, it'll launch Pianobar, which - importantly - will resume from the last station unless otherwise configured.

@JarbasAl
Copy link
Contributor

JarbasAl commented Aug 18, 2020

#35 integrates the new CPS_track_status mechanism, which allows to know what track is supposed to be on and current playback status

"play music" with #32 becomes media type MUSIC and phrase is "" empty string

i'd argue that condition is enough for this skill to also be a common play skill, and handle that case for resuming playback

it could be used check condition above

IF STATUS == PAUSED:
    RESUME
ELSE
    ALLOW OTHER SKILL TO HANDLE QUERY

maybe we need yet another status in the Enum? (Done MycroftAI/mycroft-core#2674)

the concept of a default music skill can be tackled after this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants