Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rendering to wrapped methods #8

Open
kadir1243 opened this issue May 1, 2024 · 2 comments
Open

Move rendering to wrapped methods #8

kadir1243 opened this issue May 1, 2024 · 2 comments

Comments

@kadir1243
Copy link

kadir1243 commented May 1, 2024

Seems like some pieces of rendering uses extension and direct Gl calls,
For Example DynamicLinkPanelRenderer and ShaderUtils use ARBShaderObjects extension,
ARBShaderObjects extension should not be used and usages should be replaced by OpenGlHelper
for example ModelRendererAdvanced uses direct gl calls
also seems like some parts of rendering (for example DniColorRenderer) still uses glBegin and glEnd instead of tessellator
I don't know is this a bug or feature

@XCompWiz
Copy link
Member

If it causes problems to not fix, it's a bug. If fixing it will improve performance or results in some way, it's a feature.

If neither, it's a "refactor", and mainly valuable to improve code quality (maintainability and readability).

@XCompWiz
Copy link
Member

Are you able to provide a reference for how this should be done, and why doing it is an improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants