Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create single page application example #9

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Oct 15, 2024

Based on the react router tutorial: https://reactrouter.com/en/main/start/tutorial

@Tzal3x Tzal3x self-assigned this Oct 15, 2024
@Tzal3x Tzal3x marked this pull request as ready for review October 16, 2024 08:46
@Tzal3x Tzal3x requested a review from giac-mysten October 16, 2024 08:46
Copy link
Collaborator

@giac-mysten giac-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Tzal3x ! Could we add some title on the main page, something like "Single page web app example on Walrus Sites", with a line or two on routing and a link to the docs? so that it does not look so white on load 😬

@Tzal3x Tzal3x merged commit 2a59135 into main Oct 16, 2024
7 checks passed
@Tzal3x Tzal3x deleted the tza/spa-example branch October 16, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants