enable use of system FFmpeg #428

ulmus-scott · 2021-12-08T20:50:48Z

In order to use the system supplied FFmpeg, we need to:

1. eliminate/upstream our modifications

for eliminating some of the modifications, see ffmpeg cleanup #416
for logical commits rebased onto FFmpeg/release/4.4, see https://github.com/ulmus-scott/FFmpeg/commits/rebase/4.4m3

Investigate subtitle changes/additions:

IVTV subtitles: ulmus-scott/FFmpeg@a611475 ulmus-scott/FFmpeg@2acbe0e
DVB_VBI duplicates AV_CODEC_ID_DVB_TELETEXT? ulmus-scott/FFmpeg@7bbd4d1
ATSC subtitles: ulmus-scott/FFmpeg@db04442

MPEG-TS changes

investigate what the changes actually are versus the ffmpeg version: (marking as done due to harmonization)
- attempt to upstream changes or revert them if not needed
  - in particular, upstream MHEG changes
  - placeholder for other changes

2. Only use the following FFmpeg headers (eliminate use of internal FFmpeg headers)

Headers installed by the -dev packages on Ubuntu:

libavcodec/:

ac3_parser.h
adts_parser.h
avcodec.h
avdct.h
avfft.h
bsf.h
codec_desc.h
codec.h
codec_id.h
codec_par.h
d3d11va.h
dirac.h
dv_profile.h
dxva2.h
jni.h
mediacodec.h
packet.h
qsv.h
vaapi.h
vdpau.h
version.h
videotoolbox.h
vorbis_parser.h
xvmc.h

libavdevice/:

avdevice.h
version.h

libavfilter/:

avfilter.h
buffersink.h
buffersrc.h
version.h

libavformat/:

avformat.h
avio.h
version.h

libavutil/:

adler32.h
aes_ctr.h
aes.h
attributes.h
audio_fifo.h
avassert.h
avconfig.h
avstring.h
avutil.h
base64.h
blowfish.h
bprint.h
bswap.h
buffer.h
camellia.h
cast5.h
channel_layout.h
common.h
cpu.h
crc.h
des.h
dict.h
display.h
dovi_meta.h
downmix_info.h
encryption_info.h
error.h
eval.h
ffversion.h
fifo.h
file.h
film_grain_params.h
frame.h
hash.h
hdr_dynamic_metadata.h
hmac.h
hwcontext_cuda.h
hwcontext_d3d11va.h
hwcontext_drm.h
hwcontext_dxva2.h
hwcontext.h
hwcontext_mediacodec.h
hwcontext_opencl.h
hwcontext_qsv.h
hwcontext_vaapi.h
hwcontext_vdpau.h
hwcontext_videotoolbox.h
hwcontext_vulkan.h
imgutils.h
intfloat.h
intreadwrite.h
lfg.h
log.h
lzo.h
macros.h
mastering_display_metadata.h
mathematics.h
md5.h
mem.h
motion_vector.h
murmur3.h
opt.h
parseutils.h
pixdesc.h
pixelutils.h
pixfmt.h
random_seed.h
rational.h
rc4.h
replaygain.h
ripemd.h
samplefmt.h
sha512.h
sha.h
spherical.h
stereo3d.h
tea.h
threadmessage.h
timecode.h
time.h
timestamp.h
tree.h
twofish.h
tx.h
version.h
video_enc_params.h
xtea.h

libpostproc/:

postprocess.h
version.h

libswresample/:

swresample.h
version.h

libswscale/:

swscale.h
version.h

Used internal headers

libavformat/

url.h (Priority: LOW; only transitive includes are public headers)
- It was deprecated a decade ago (when it was part of avio.h). Functions in avio.h may replace url.h?
- see Eliminate usage of internal FFmpeg headers #931
mythtv/libs/libmythtv/decoders/avformatdecoder.cpp:41:#include "libavformat/internal.h" // for ff_read_frame_flush see ffmpeg cleanup #416

libavcodec

mythtv/libs/libmythfreesurround/el_processor.cpp:31:#include "libavcodec/fft.h" see libmythfreesuround cleanup (remove internal FFmpeg header fft.h) #462
#include "libavcodec/internal.h" // for avpriv_find_start_code see ffmpeg cleanup #416
- mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
- mythtv/libs/libmythtv/mpeg/AVCParser.cpp
- mythtv/libs/libmythtv/mpeg/HEVCParser.cpp
- mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
- mythtv/programs/mythutil/mpegutils.cpp
mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp:27:#include "libavcodec/v4l2_request.h" ?
- #ifdefed out and the file referenced is created in an out of tree patch to FFmpeg
- see Add V4L2 request support #278 and MythV4L2M2MContext: Prepare for planned V4L2 Request API hwaccel changes #929
golomb.h and get_bits.h see ffmpeg cleanup #416
- mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
- mythtv/libs/libmythtv/mpeg/AVCParser.cpp
- mythtv/libs/libmythtv/mpeg/HEVCParser.cpp

libavutil/

internal.h see ffmpeg cleanup #416
- mythtv/libs/libmythtv/mpeg/AVCParser.cpp
- mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
- mythtv/libs/libmythtv/mpeg/HEVCParser.cpp
mythtv/libs/libmythtv/mythdeinterlacer.cpp: see replace configure's ARCH... with Q_PROCESSOR_... v2 #487

The text was updated successfully, but these errors were encountered:

ulmus-scott · 2021-12-12T00:10:06Z

Regarding libavcodec/get_bits.h (and golomb.h), we would need to write our own (or use someone else's) C++ version.

Alternatively, we could use FFmpeg's parsers: FFmpeg: Frame parsing
Most of the information we use is stored in the AVCodecParserContext, but the frame rate is stored in the complementary AVCodecContext.

ulmus-scott · 2022-01-13T03:08:20Z

libavutil/internal.h appears to be for

// This can be enabled to allow detection of additional integer overflows with ubsan
//#define CHECKED
...
// For debuging we use signed operations so overflows can be detected (by ubsan)
// For production we use unsigned so there are no undefined operations
#ifdef CHECKED
#define SUINT   int
#define SUINT32 int32_t
#else
#define SUINT   unsigned
#define SUINT32 uint32_t
#endif

SUINT is conditionally used once in libavcodec/golomb.h in get_ur_golomb_jpegls(), which is itself not used in the MythTV code.

references MythTV#428 libavutil/internal.h appears to be for ``` // This can be enabled to allow detection of additional integer overflows with ubsan //#define CHECKED ... // For debuging we use signed operations so overflows can be detected (by ubsan) // For production we use unsigned so there are no undefined operations ifdef CHECKED define SUINT int define SUINT32 int32_t else define SUINT unsigned define SUINT32 uint32_t endif ``` `SUINT` is conditionally used once in libavcodec/golomb.h in `get_ur_golomb_jpegls()`, which is itself not used in the MythTV code.

originally from MythTV@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV#428 If this causes an issue, a new ticket with logs and a sample should be openned.

originally from MythTV/mythtv@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV/mythtv#428 If this causes an issue, a new ticket with logs and a sample should be openned.

References MythTV#428

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: MythTV#428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. The new parameter is always false in MythTV for no functional change. Several uses are explicit about using the history in the comments prior to the call. However, FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end().

refs: MythTV#428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): I disabled the audio check requiring the internal struct to be defined. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

originally from MythTV/mythtv@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV/mythtv#428 If this causes an issue, a new ticket with logs and a sample should be openned.

references MythTV#428 libavutil/internal.h appears to be for ``` // This can be enabled to allow detection of additional integer overflows with ubsan //#define CHECKED ... // For debuging we use signed operations so overflows can be detected (by ubsan) // For production we use unsigned so there are no undefined operations ifdef CHECKED define SUINT int define SUINT32 int32_t else define SUINT unsigned define SUINT32 uint32_t endif ``` `SUINT` is conditionally used once in libavcodec/golomb.h in `get_ur_golomb_jpegls()`, which is itself not used in the MythTV code.

originally from MythTV@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV#428 If this causes an issue, a new ticket with logs and a sample should be openned.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: MythTV#428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. The new parameter is always false in MythTV for no functional change. Several uses are explicit about using the history in the comments prior to the call. However, FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end().

refs: MythTV#428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

References MythTV#428

References #428

references MythTV#428 libavutil/internal.h appears to be for ``` // This can be enabled to allow detection of additional integer overflows with ubsan //#define CHECKED ... // For debuging we use signed operations so overflows can be detected (by ubsan) // For production we use unsigned so there are no undefined operations ifdef CHECKED define SUINT int define SUINT32 int32_t else define SUINT unsigned define SUINT32 uint32_t endif ``` `SUINT` is conditionally used once in libavcodec/golomb.h in `get_ur_golomb_jpegls()`, which is itself not used in the MythTV code.

originally from MythTV@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV#428 If this causes an issue, a new ticket with logs and a sample should be openned.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: MythTV#428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. The new parameter is always false in MythTV for no functional change. Several uses are explicit about using the history in the comments prior to the call. However, FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end().

refs: MythTV#428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

references MythTV#428 libavutil/internal.h appears to be for ``` // This can be enabled to allow detection of additional integer overflows with ubsan //#define CHECKED ... // For debuging we use signed operations so overflows can be detected (by ubsan) // For production we use unsigned so there are no undefined operations ifdef CHECKED define SUINT int define SUINT32 int32_t else define SUINT unsigned define SUINT32 uint32_t endif ``` `SUINT` is conditionally used once in libavcodec/golomb.h in `get_ur_golomb_jpegls()`, which is itself not used in the MythTV code.

originally from MythTV@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV#428 If this causes an issue, a new ticket with logs and a sample should be openned.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: MythTV#428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. The new parameter is always false in MythTV for no functional change. Several uses are explicit about using the history in the comments prior to the call. However, FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end().

refs: MythTV#428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

references MythTV#428 libavutil/internal.h appears to be for ``` // This can be enabled to allow detection of additional integer overflows with ubsan //#define CHECKED ... // For debuging we use signed operations so overflows can be detected (by ubsan) // For production we use unsigned so there are no undefined operations ifdef CHECKED define SUINT int define SUINT32 int32_t else define SUINT unsigned define SUINT32 uint32_t endif ``` `SUINT` is conditionally used once in libavcodec/golomb.h in `get_ur_golomb_jpegls()`, which is itself not used in the MythTV code.

originally from MythTV@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV#428 If this causes an issue, a new ticket with logs and a sample should be openned.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: MythTV#428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. The new parameter is always false in MythTV for no functional change. Several uses are explicit about using the history in the comments prior to the call. However, FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end().

refs: MythTV#428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

This should have no functional change. References MythTV#428

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: MythTV#428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end(). So, I have split the truncated start code logic into its own function as I have now done for FFmpeg, which only used this functionality once. Determining if it is necessary would require further analysis or adding logging to see if truncated start codes are detected.

This should have no functional change. References MythTV#428 The hack is no longer necessary since internal FFmpeg headers are no longer included by the parsers. avformatdecoder.cpp needed the public FFmpeg header "libavutil/intreadwrite.h".

originally from MythTV@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV#428 If this causes an issue, a new ticket with logs and a sample should be openned.

refs: #428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: #428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end(). So, I have split the truncated start code logic into its own function as I have now done for FFmpeg, which only used this functionality once. Determining if it is necessary would require further analysis or adding logging to see if truncated start codes are detected.

This should have no functional change. References #428 The hack is no longer necessary since internal FFmpeg headers are no longer included by the parsers. avformatdecoder.cpp needed the public FFmpeg header "libavutil/intreadwrite.h".

originally from 0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References #428 If this causes an issue, a new ticket with logs and a sample should be openned.

refs: #428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: #428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end(). So, I have split the truncated start code logic into its own function as I have now done for FFmpeg, which only used this functionality once. Determining if it is necessary would require further analysis or adding logging to see if truncated start codes are detected.

This should have no functional change. References #428 The hack is no longer necessary since internal FFmpeg headers are no longer included by the parsers. avformatdecoder.cpp needed the public FFmpeg header "libavutil/intreadwrite.h".

originally from 0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References #428 If this causes an issue, a new ticket with logs and a sample should be openned.

refs: MythTV#428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: MythTV#428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end(). So, I have split the truncated start code logic into its own function as I have now done for FFmpeg, which only used this functionality once. Determining if it is necessary would require further analysis or adding logging to see if truncated start codes are detected.

This should have no functional change. References MythTV#428 The hack is no longer necessary since internal FFmpeg headers are no longer included by the parsers. avformatdecoder.cpp needed the public FFmpeg header "libavutil/intreadwrite.h".

originally from MythTV@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV#428 If this causes an issue, a new ticket with logs and a sample should be openned.

refs: #428 ff_read_frame_flush() is an internal FFmpeg function. However, in libavformat/utils.c: int avformat_flush(AVFormatContext *s) { ff_read_frame_flush(s); return 0; } avformat_flush() is exactly identical and is a public function, so use it instead. StreamHasRequiredParameters(): The audio check requiring the internal struct to be defined was disabled. This should have no effect since these checks are *all* already done via avformat_find_stream_info() in FindStreamInfo(), which should return < 0 if these checks fail. This copy of an internal FFmpeg function feels unnecessary and like a bad idea since FFmpeg already checks this itself.

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code(). Refs: #428 Note: I have rewritten this function. The only functional change is 00 00 01 00 01 XX no longer incorrectly returns a start code at offset 7 that overlaps the start code at offset 4 if the start_code input is not modified between the two calls. FFmpeg only has one use that keeps the history, (ff_)mpeg1_find_frame_end(). So, I have split the truncated start code logic into its own function as I have now done for FFmpeg, which only used this functionality once. Determining if it is necessary would require further analysis or adding logging to see if truncated start codes are detected.

This should have no functional change. References #428 The hack is no longer necessary since internal FFmpeg headers are no longer included by the parsers. avformatdecoder.cpp needed the public FFmpeg header "libavutil/intreadwrite.h".

originally from 0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References #428 If this causes an issue, a new ticket with logs and a sample should be openned.

KungFuJesus · 2022-09-10T15:40:40Z

I realize this isn't the most appropriate place to bring this up but...there seems to be a regression that was introduced into FFmpeg on the version that's incorporated into the fixes/32 branch. There are blocking artifacts with MPEG-TS demuxing when using nvdec or VDPAU for decoding (and I've seen evidence that va-api also occasionally sees this issue). It's particularly noticeable on interlaced content for some reason. For a time, mpv also seemed to have this issue, which as far as I know leverages my system installed FFmpeg. Some time recently I updated FFmpeg to 4.4.2 and those artifacts disappeared. Whether that was working around latent ffmpeg behavior on their part (I searched their repo, couldn't find any meaningful messages) or FFmpeg fixed a bug, I'm not sure.

I will say the closest thing I've found to evidence and a workaround for this in the mythtv repo was the H264 blocking artifact fix here: c257bacbfe

All of this is to say, I'm hoping a release is turned around with these fixes soon - it'd be great to see if this regression is fixed.

ulmus-scott · 2022-09-10T17:35:04Z

@KungFuJesus You should have opened a new bug report.

Does your blocking look like https://trac.ffmpeg.org/attachment/ticket/9532/tweevoortwaalf_ffmpeg.png ? Because that is what the commit you mentioned fixed. That blocking occurred at the start and (sometimes) on skipping.

KungFuJesus · 2022-09-10T17:42:38Z

Yes, though blocking artifacts I'm sure is a broad symptom. It seems most common when there's a moment of fast transition where the compression has to make more out of the bitrate. It goes away when using software decoding or when the mpeg transport stream is removed with a lossless transcode. I'll get you a screenshot.

KungFuJesus · 2022-09-10T17:45:05Z

KungFuJesus · 2022-09-10T17:45:50Z

I can send you the whole transport stream but it's pretty huge. I don't have a great place to readily host it.

ulmus-scott · 2022-09-10T19:38:28Z

@bennettpeter Thoughts on this blocking? It sounds different to me from what Klaas found. If you think it worthwhile, I can try merging the upstream FFmpeg release/4.4 into ours again for fixes/32.

@KungFuJesus You can chop an MPEG Transport Stream at any arbitrary place, e.g. with dd, to create a smaller sample.

when the mpeg transport stream is removed with a lossless transcode.

So if I understand correctly, the blocking only occurs on .ts files and not after lossless cutting and remuxing to .mpg?

What hardware are you using and is this replicable on another system?

I would like you to attach a log from mythfrontend -v playback:debug --logpath=SOME_PATH, where SOME_PATH is a valid path, of playing a file that shows the blocking.

KungFuJesus · 2022-09-10T19:52:11Z

So if I understand correctly, the blocking only occurs on .ts files and not after lossless cutting and remuxing to .mpg?

Yes from what I remember.

What hardware are you using and is this replicable on another system?

Yes, every system I've tested on using vdpau or nvdec decoding reproduces this. This particular system is fairly old hardware but I've produced this on Maxwell and pascal based hardware using both nvdec and vdpau.

I would like you to attach a log from mythfrontend -v playback:debug --logpath=SOME_PATH, where SOME_PATH is a valid path, of playing a file that shows the blocking.

Will do so when I'm home. I can also cut up a short duration TS if it's feasible to upload on GitHub. I saw one person around November of last year report a similar issue on the mythtv forums. I'll open up a new issue with all the details and sample file, log output, forum post, etc.

It appears to be some bizarre abomination where the left and right audio channels of a stereo stream are in different languages. See for reference (Add support for ivtv-generated bilingual dual audio MPEG) https://code.mythtv.org/trac/ticket/2439 Record side of PVR-x50 SAP support patch from szermatt at… MythTV/mythtv@435540c Record side of PVR-x50 SAP support patch from szermatt at… MythTV/mythtv@435540c Applies UI portion of "dual audio" patch. MythTV/mythtv@8bb0d4b Fix reversed logic in test used for MPEG dual audio supp… MythTV/mythtv@60deced Set correct audio mode for ivtv drivers using V4L2 MPEG … MythTV/mythtv@28619ff Fix ivtv dual language mode regression from [14800] ffmpeg sync MythTV/mythtv@ea0c398 lavc/mpegaudio_parser.c: revert MythTV workaround originally from MythTV/mythtv@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV/mythtv#428 If this causes an issue, a new ticket with logs and a sample should be openned. (cherry picked from commit fdfdbd9)

ulmus-scott mentioned this issue Jan 13, 2022

libmythfreesuround cleanup (remove internal FFmpeg header fft.h) #462

Merged

6 tasks

ulmus-scott added a commit to ulmus-scott/mythtv that referenced this issue Feb 1, 2022

mythdeinterlacer.cpp: remove use of internal FFmpeg headers

7a6a607

References MythTV#428

ulmus-scott added a commit to ulmus-scott/mythtv that referenced this issue Feb 17, 2022

mythdeinterlacer.cpp: remove use of internal FFmpeg headers

c8d227a

References MythTV#428

linuxdude42 pushed a commit that referenced this issue Feb 18, 2022

mythdeinterlacer.cpp: remove use of internal FFmpeg headers

4eeaa5d

References #428

ulmus-scott added a commit to ulmus-scott/mythtv that referenced this issue Apr 4, 2022

replace internal ffmpeg headers with BitReader

e4283e9

This should have no functional change. References MythTV#428

KungFuJesus mentioned this issue Sep 11, 2022

Blocking artifacts with mpeg-ts in fixes/32 when using nvdec or vdpau #634

Closed

ulmus-scott mentioned this issue Dec 5, 2022

No ATSC CEA-608/EIA-708 Closed Caption subtitles with NVDEC #364

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable use of system FFmpeg #428

enable use of system FFmpeg #428

ulmus-scott commented Dec 8, 2021 •

edited

Loading

ulmus-scott commented Dec 12, 2021 •

edited

Loading

ulmus-scott commented Jan 13, 2022

KungFuJesus commented Sep 10, 2022

ulmus-scott commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022

ulmus-scott commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022 •

edited

Loading

enable use of system FFmpeg #428

enable use of system FFmpeg #428

Comments

ulmus-scott commented Dec 8, 2021 • edited Loading

1. eliminate/upstream our modifications

2. Only use the following FFmpeg headers (eliminate use of internal FFmpeg headers)

libavcodec/:

libavdevice/:

libavfilter/:

libavformat/:

libavutil/:

libpostproc/:

libswresample/:

libswscale/:

Used internal headers

libavformat/

libavcodec

libavutil/

ulmus-scott commented Dec 12, 2021 • edited Loading

ulmus-scott commented Jan 13, 2022

KungFuJesus commented Sep 10, 2022

ulmus-scott commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022

ulmus-scott commented Sep 10, 2022

KungFuJesus commented Sep 10, 2022 • edited Loading

ulmus-scott commented Dec 8, 2021 •

edited

Loading

ulmus-scott commented Dec 12, 2021 •

edited

Loading

KungFuJesus commented Sep 10, 2022 •

edited

Loading