Migrate from bindValue(..., null_to_empty(x)) to bindValueNoNull(..., x) #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garybuhrmaster
force-pushed
the
bindValueNoNull-migration
branch
3 times, most recently
from
261c4cf
to
05dcb57
Compare
garybuhrmaster
force-pushed
the
bindValueNoNull-migration
branch
6 times, most recently
from
9510698
to
7ba64fa
Compare
garybuhrmaster
force-pushed
the
bindValueNoNull-migration
branch
from
7ba64fa
to
a7e9b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change.
bindValueNoNull was introduced in 19a51cb and some codes previously migrated. Take another step in the migration for recordinginfo.cpp (similar fixes were introduced in 334c4cf, 28e98a8 (and probably others)).
If accepted (and PR #963 merged) I'll also look at migrating programdata.cpp to bindValueNoNull