Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Pydantic v2 #400

Open
2 tasks
smohiudd opened this issue Jul 18, 2024 · 1 comment
Open
2 tasks

Upgrade to Pydantic v2 #400

smohiudd opened this issue Jul 18, 2024 · 1 comment
Assignees
@botanical

Comments

@smohiudd
Copy link
Contributor

smohiudd commented Jul 18, 2024 •
edited
Loading

Description

The STAC and Ingest APIs are both using packages that have Pydantic V1 as a dependency:

Ingest API:

The Ingest API is using a forked/pinned version of stac-pydantic which is still using pydantic v1. The changes from that fork should now be available in a new version of stac-pydantic so we should now upgrade to stac-pydantic >=v3.0.x. (which uses pydantic v2).

STAC API

The STAC Api is using stac-fastapi v2.4 which uses Pydantic v1. stac-fastapi >=3.0 uses Pydantic v2

Acceptance Criteria

  • Ingest API (stac-pydantic) is using stac-pydantic version that uses pydantic v2 and tested using endpoints and Airflow
  • STAC API (stac-fastapi) is using >=3.0
@smohiudd smohiudd changed the title Ingest API unpin pydantic Upgrade to Pydantic v2 Aug 27, 2024
@smohiudd
Copy link
Contributor Author

Migration guide: https://docs.pydantic.dev/latest/migration/

@botanical botanical self-assigned this Sep 4, 2024
@botanical botanical mentioned this issue Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@botanical botanical

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@botanical @smohiudd