Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the datasets for analysis #675

Merged
merged 24 commits into from
Sep 27, 2023
Merged

Limit the datasets for analysis #675

merged 24 commits into from
Sep 27, 2023

Conversation

hanbyul-here
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit e85073e
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/6514145e4ef54f0008a967f5
😎 Deploy Preview https://deploy-preview-675--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here requested a review from nerik September 25, 2023 14:46
@nerik nerik force-pushed the feature/limit-stat branch from dfac5f0 to 441f059 Compare September 25, 2023 14:50
@hanbyul-here
Copy link
Collaborator Author

Heads-up that there might be some datasets that is not periodic without dates available through summaries.datetime. @anayeaye explained this to me this happens when the dataset didn't go through the ingestion pipeline. (ex. put directly to database because of some issues at that time etc.) I think it is fine considering that not-periodic data is never that dense, but good to know.

@nerik nerik changed the base branch from main to ghg September 26, 2023 08:56
nerik and others added 19 commits September 26, 2023 11:06
@nerik
Updated analysis flow wording
f1e7171
@nerik
Added sticky footer
9b24cd4
@nerik
Prevent users from selecting datasets with too many data points
35bd7fa
@nerik
Fixed number of data points estimate when isPeriodic=false using time…
2af6225 
…series
@nerik
Changed date presets
0a4a000
@nerik
Replace reset icon
a67f413
@nerik
Added north america preset
fd884ee
@hanbyul-here
Fix getNumberOfItem logic when dataset is not periodic, add unit test
30ec70b 
for the function
@hanbyul-here
Style for 1,2,3 step
7f5c11f
@hanbyul-here
Use fold for footer items
180447b
@hanbyul-here
Align date selection tools, lint
d27f634
@nerik
Select 2018-2022 date range by default
ee5a107
@nerik
Hardcode min and max dates to 1980-01-01 through 2022-12-31
a40244d
@nerik
Initialize the map with North America AoI
f9ae022
@j08lue
Correct month
5c7a87d
@nerik
Revert "Correct month"
15a3227 
This reverts commit 5c7a87d.
@nerik
Revert "Initialize the map with North America AoI"
240017f 
This reverts commit f9ae022.
@nerik
Some design polish
9abac3b
@nerik
Feature/analysis flow (#677)
e85073e 
Implements US-GHG-Center/veda-config-ghg#129
@nerik nerik marked this pull request as ready for review September 27, 2023 11:39
@nerik nerik merged commit 31a9865 into ghg Sep 27, 2023
5 checks passed
@nerik nerik deleted the feature/limit-stat branch September 27, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerik nerik Awaiting requested review from nerik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanbyul-here @nerik @j08lue