From 5b787d49a55be69c2e426edc825ce9b3b03f5162 Mon Sep 17 00:00:00 2001 From: Qui T Chau Date: Thu, 11 Feb 2021 13:50:48 -0800 Subject: [PATCH] Add empty files to directories otherwise git will ignore them from repository. 1. Add empty files to 'data', 'browse' and 'calibration' dirctories. 2. Correct message from errors to warnings for "github 240 test 2" to validate.feature Refs #282 https://github.com/NASA-PDS/validate/issues/282 Implement initial framework to be able to start developing tests #283 https://github.com/NASA-PDS/validate/issues/283 Implement initial test to exercise framework #240 https://github.com/NASA-PDS/validate/issues/240 RuleUnexpected error for data collection in a sub-directory #290 https://github.com/NASA-PDS/validate/issues/290 Migrate subset of existing regression tests to cucumber behavioral testing --- src/test/resources/features/validate.feature | 2 +- .../github240/invalid/data_spectra/browse/empty_file.txt | 0 .../github240/invalid/data_spectra/calibration/empty_file.txt | 0 .../github240/invalid/data_spectra/data/empty_file.txt | 0 4 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 src/test/resources/github240/invalid/data_spectra/browse/empty_file.txt create mode 100644 src/test/resources/github240/invalid/data_spectra/calibration/empty_file.txt create mode 100644 src/test/resources/github240/invalid/data_spectra/data/empty_file.txt diff --git a/src/test/resources/features/validate.feature b/src/test/resources/features/validate.feature index 576cd3956..f82827fa3 100644 --- a/src/test/resources/features/validate.feature +++ b/src/test/resources/features/validate.feature @@ -37,7 +37,7 @@ Scenario Outline: Execute validate command for tests below. |"NASA-PDS/validate#6 1" | "github6" | 9 | "9 errors expected for FILE_NAME_HAS_INVALID_CHARS,UNALLOWED_BASE_NAME,UNALLOWED_FILE_NAME,DIR_NAME_HAS_INVALID_CHARS." | "FILE_NAME_HAS_INVALID_CHARS,UNALLOWED_BASE_NAME,UNALLOWED_FILE_NAME,DIR_NAME_HAS_INVALID_CHARS" | "src/test/resources" | "target/test" | "-R pds4.bundle -r {reportDir}/report_github6_bundle_invalid_cucumber.json -s json {resourceDir}/github6/invalid/bundle_kaguya_derived.xml" | "report_github6_bundle_invalid_cucumber.json" | |"NASA-PDS/validate#6 2" | "github6" | 0 | "0 errors expected for totalErrors." | "totalErrors" | "src/test/resources" | "target/test" | "-R pds4.bundle -r {reportDir}/report_github6_bundle_valid_cucumber.json -s json {resourceDir}/github6/valid/bundle_kaguya_derived.xml" | "report_github6_bundle_valid_cucumber.json" | |"NASA-PDS/validate#240 1" | "github240" | 0 | "0 errors expected for totalErrors." | "totalErrors" | "src/test/resources" | "target/test" | "-R pds4.bundle -r {reportDir}/report_github240_bundle_valid_cucumber.json -s json {resourceDir}/github240/valid/bundle_kaguya_derived.xml" | "report_github240_bundle_valid_cucumber.json" | - |"NASA-PDS/validate#240 2" | "github240" | 3 | "3 errors expected for UNALLOWED_BUNDLE_SUBDIR_NAME." | "UNALLOWED_BUNDLE_SUBDIR_NAME" | "src/test/resources" | "target/test" | "-R pds4.bundle -r {reportDir}/report_github240_bundle_invalid_cucumber.json -s json {resourceDir}/github240/invalid/bundle_kaguya_derived.xml" | "report_github240_bundle_invalid_cucumber.json" | + |"NASA-PDS/validate#240 2" | "github240" | 3 | "3 warnings expected for UNALLOWED_BUNDLE_SUBDIR_NAME." | "UNALLOWED_BUNDLE_SUBDIR_NAME" | "src/test/resources" | "target/test" | "-R pds4.bundle -r {reportDir}/report_github240_bundle_invalid_cucumber.json -s json {resourceDir}/github240/invalid/bundle_kaguya_derived.xml" | "report_github240_bundle_invalid_cucumber.json" | # https://github.com/NASA-PDS/validate/issues/15 Verify that all name/type attribute values correspond to names denoted context products diff --git a/src/test/resources/github240/invalid/data_spectra/browse/empty_file.txt b/src/test/resources/github240/invalid/data_spectra/browse/empty_file.txt new file mode 100644 index 000000000..e69de29bb diff --git a/src/test/resources/github240/invalid/data_spectra/calibration/empty_file.txt b/src/test/resources/github240/invalid/data_spectra/calibration/empty_file.txt new file mode 100644 index 000000000..e69de29bb diff --git a/src/test/resources/github240/invalid/data_spectra/data/empty_file.txt b/src/test/resources/github240/invalid/data_spectra/data/empty_file.txt new file mode 100644 index 000000000..e69de29bb