Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate subset of existing regression tests to cucumber behavioral testing #290

Closed
jordanpadams opened this issue Jan 27, 2021 · 1 comment
Closed

Migrate subset of existing regression tests to cucumber behavioral testing #290

jordanpadams opened this issue Jan 27, 2021 · 1 comment
Assignees
@qchaupds
Labels
B11.1 enhancement New feature or request p.should-have
Milestone
03.Wyomia.Tyus

Comments

@jordanpadams
Copy link
Member

Let's migrate tests from this build to the new framework started in #282. here are a list of issues we can use for reference, but we do not need to create any new tests. Let's just migrate those that already have regression tests.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Applicable requirements
🦄 #1
🦄 #2
@jordanpadams jordanpadams added enhancement New feature or request medium labels Jan 27, 2021
@jordanpadams jordanpadams added this to the 02.Marion.Jones milestone Jan 28, 2021
qchaupds pushed a commit that referenced this issue Jan 28, 2021
Implement initial framework to be able to start developing tests and …
b1982de 
…improve error handling for data collection in a sub-directory

1. Add github240 test resources to src/test/resources
2. Add cucumber dependencies to pom.xml
3. Add cucumber feature artifacts to src/test/resources for initial cucumber behavior testing
4. Migrate subset of integration tests to cucumber tests (via the validate.feature file) to new class src/test/java/cucumber/StepDefs.java
5. Change report type to WARNING and message in PDS4Problems.java
6. Add debug to SubdirectoryNamingRule.java

Refs #282 #282 Implement initial framework to be able to start developing tests
     #283 #283 Implement initial test to exercise framework
     #240 #240 RuleUnexpected error for data collection in a sub-directory
     #290 #290 Migrate subset of existing regression tests to cucumber behavioral testing
@qchaupds qchaupds mentioned this issue Jan 28, 2021
Merged
@tloubrieu-jpl
Copy link
Member

@qchaupds has issue with integration of cucumber test in maven.

qchaupds pushed a commit that referenced this issue Feb 2, 2021
Add logic to allow cucumber tests to run from maven. Running from com…
3926c7a 
…mand line is also available.

1. Add profile 'cucumber-test-run' to allow maven to run cucumber test to pom.xml
2. Add new java class FileFinder.java to search for resource validation-commands.xml
3. Add logic to find validation-commands.xml due to resource null when ran from maven to LocationValidator.java
4. Add logic to find validation-commands.xml due to resource null when ran from maven to ValidationResourceManager.java

Refs #282 #282 Implement initial framework to be able to start developing tests
     #283 #283 Implement initial test to exercise framework
     #240 #240 RuleUnexpected error for data collection in a sub-directory
     #290 #290 Migrate subset of existing regression tests to cucumber behavioral testing
qchaupds pushed a commit that referenced this issue Feb 10, 2021
Migrate all tests from ValidationIntegrationTests.java to cucumber fr…
5cea382 
…amework due to issue with running tests simultaneously.

1. Add test resource to github153 due to cucumber feature does not play well with spaces in file name.
2. Add more enumerated problem types and correct search for "validate#71" to build catalog file in StepDefs.java
3. Migrate all integration tests to validate.feature

Refs #282 #282 Implement initial framework to be able to start developing tests
     #283 #283 Implement initial test to exercise framework
     #240 #240 RuleUnexpected error for data collection in a sub-directory
     #290 #290 Migrate subset of existing regression tests to cucumber behavioral testing
qchaupds pushed a commit that referenced this issue Feb 11, 2021
Add empty files to directories otherwise git will ignore them from re…
5b787d4 
…pository.

1. Add empty files to 'data', 'browse' and 'calibration' dirctories.
2. Correct message from errors to warnings for "github 240 test 2" to validate.feature

Refs #282 #282 Implement initial framework to be able to start developing tests
     #283 #283 Implement initial test to exercise framework
     #240 #240 RuleUnexpected error for data collection in a sub-directory
     #290 #290 Migrate subset of existing regression tests to cucumber behavioral testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qchaupds qchaupds

Labels
B11.1 enhancement New feature or request p.should-have
Projects
None yet
Milestone
03.Wyomia.Tyus
Development

No branches or pull requests
3 participants
@jordanpadams @tloubrieu-jpl @qchaupds