Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate does not allow a single-character subdirectory #423

Closed
Tracked by #9
c-suh opened this issue Oct 22, 2021 · 2 comments
Closed
Tracked by #9

Validate does not allow a single-character subdirectory #423

c-suh opened this issue Oct 22, 2021 · 2 comments
Assignees
Labels
B12.1 bug Something isn't working s.medium
Milestone

Comments

@c-suh
Copy link

c-suh commented Oct 22, 2021

🐛 Describe the bug

Validate tool fails a product if the transfer manifest .tab file has a directory spec with a single-character subdirectory. Very similar to #299.

📜 To Reproduce

Steps to reproduce the behavior:

  1. Run validate on the files inside gbo.ast.alcdef-database_v1.0_20211021.zip
  2. Read output. Or skip step 1 and read this saved output: gbo.ast.alcdef-database_v1.0_20211021-validate.txt

🕵️ Expected behavior

A directory spec such as '/data/1/' should not cause an error.

📚 Version of Software Used

2.1.0 (but also exists in 2.0.7. Have not tested earlier versions)

🩺 Test Data / Additional context

Actual data available under "To Reproduce". Going by comments from #299 and the pattern shown in the validate report, perhaps adding a star after the first grouping would solve this issue?
Currently: /?([A-Za-z0-9][A-Za-z0-9_-]*[A-Za-z0-9]/?)*
Proposed: /?([A-Za-z0-9]*[A-Za-z0-9_-]*[A-Za-z0-9]/?)*


🦄 Related requirements

⚙️ Engineering Details

@jordanpadams
Copy link
Member

From SR, looks like it will be a little more complicated:

The directory name must not begin or end with a dash or underscore.

@jpl-jengelke
Copy link
Contributor

This passes tests with validate 2.2.0-SNAPSHOT with the error resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.1 bug Something isn't working s.medium
Projects
None yet
Development

No branches or pull requests

4 participants