-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physics changes for new ccpp framework (Capgen) #1085
Open
dustinswales
wants to merge
16
commits into
NCAR:main
Choose a base branch
from
dustinswales:changes_for_capgen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
914031d
Initial bunch of changes for Capgen unification
740d665
GFS_MP_generic_post.F90
dustinswales 7227d10
Changes to LSM variable name
dustinswales d1f3f7d
Added kinds file to physics CmakeLists
dustinswales c1a141a
Chnage to DDT metadata in radiation
dustinswales 9a38a0c
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD
dustinswales 98607b9
Metadata changes for Capgen
dustinswales 7916da7
Add in optional attributre
dustinswales 318e661
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD
dustinswales 265bb57
Some more changes...
dustinswales 6f18a9e
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into chan…
dustinswales b853dd7
Revert some changes. Cleanup
dustinswales d7e8c7e
Revert some more changes. Cleanup
dustinswales b644147
Address reviewers comments. Additional bug fixes.
dustinswales 30d3036
Changes type instances name
dustinswales f20b728
Merge branch 'changes_for_capgen' of https://github.com/dustinswales/…
dustinswales File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI. I haven't modified the physics to use this autogenerated type yet. The physics schemes still reference physics/hooks/machine.F to access the working precision. In the "post-capgen cleanup phase", I plan to implement the framework autogenerated kinds within the physics