Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam:kp unexpectedly still in ARS #425

Open
edeutsch opened this issue Jun 14, 2023 · 5 comments
Open

cam:kp unexpectedly still in ARS #425

edeutsch opened this issue Jun 14, 2023 · 5 comments
Assignees

Comments

@edeutsch
Copy link
Contributor

This issue ended up in the ARAX repo issues list, but if I understand it correctly, this is an ARS issue. ARS seems to be calling and listing cam-kp probably because it is hard coded in a list somewhere rather than fully dynamic?

See:
RTXteam/RTX#2050

@edeutsch
Copy link
Contributor Author

From @gaurav

Hi there! We've been working on moving CAM-KP into Automat. As part of that process, we have deleted every TRAPI 1.3 CAM-KP instance from SmartAPI and instead registered an Automat-CAM-KP instance. All of these are correctly visible in https://arax.ncats.io/?smartapi=1, where we see:

Automat-cam-kp(Trapi v1.4.0) (infores:automat-cam-kp) in staging, testing and development.
CAM-KP API (infores:cam-kp) on TRAPI 1.3 in development
On running a recent query through the UI, I noticed that agent kp-cam returned a 404 error. However, all of the CAM-KP instances mentioned above should be working. Is there some other place where we should change the reference from kp-cam to automat-cam-kp so that ARAX can retrieve results from it correctly?

@edeutsch
Copy link
Contributor Author

(ARAX is just displaying what ARS provides, so I think this is an ARS issue)

@ShervinAbd92
Copy link
Collaborator

hi @edeutsch we have updated ARS reference on automat-camp-kp. it should now point to 1.4 CI url. i just ran a quick query and i did get a 200. can you please test it out on your query and let us know if the issue is fixed?

@edeutsch
Copy link
Contributor Author

Looks good thanks!

As a side note, I am wondering if it is worth reviewing all the targets that ARS hits? The list of KPs would seem to be only a partial list. And at the Relay, there seemed to be confusion if we should even be calling Robokop, and I think it was said that Robokop was a KP for Aragorn, not an ARA? And should the ARS even be calling KPs directly anymore? or is it time to limit the ARS just to the main ARAs? I don't the answers to these, but I'm wondering if a fresh look at this is warranted. Bring up at Architecture next week?

@MarkDWilliams
Copy link
Collaborator

Sure, I think this would be worth reviewing in Architecture, and changing what the ARS hits is a pretty simple task. The design aim was certainly not to hit the KPs forever, and it may be time to take a fresh look at whether now is the time to make that cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants