-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ESS-DIVE suite #423
Comments
@vchendrix has requested that the new suite be version 1.1.0 |
Discussion topics for the ESS-DIVE Suite update ESS-DIVE Suite
Checks - the latest update to this section is from a 2022 01 05 meeting with Joan, Emily and Peter
|
Fuzzy Matches in R: https://cran.r-project.org/web/packages/stringdist/stringdist.pdf |
@gothub For the resource.URLs.resolvable check - can we add that the output includes up to 3 specific urls that were not resolvable? For resource.projectTitle.controlled - when there is no exact match for the entered project name, add suggested method for users to find project name (Emily to send text for this) |
@JEDamerow yes - I'll update resource.URLs.resolvable and resource.projectTitle.controlled as you described above. |
Issue #423 Remove 'resource.landingPage.present' check from the ESS-DIVE 1.1.0 suite
@gothub we decided to include a funder check to make sure that at least one specific funding source is listed "U.S. DOE > Office of Science > Biological and Environmental Research (BER)" Adding a note in that issue. |
Issue #423 Update the ESS-DIVE 1.1.0 suite file, so that check '<level>' settings match the 1.0 suite.
We did a spot check today of some of the assessment reports, and found a few issues to fix, or discuss. Notes on spot check issues encountered, with screenshots. Summary of Issues:Proprietary File check Project Name check Private Datasets - “An Identifier”, and not running checks Private dataset - Metadata identifier URL in metadata Funding Organization |
@JEDamerow @emilyarobles thanks for the review. Regarding your comments: Proprietary File check TODO: Need to determine a name for this new check Project Name check Private Datasets - “An Identifier”, and not running checks
This check simply looks for '/eml/@packageId' which is the identifier associated with the metadata document. Which dataset had this error?
This was due to a processing error that has been resolved, and shouldn't happen again. Private dataset - Metadata identifier
The metadig engine has privilege to read private datasets, but the checks themselves run as unprivileged, so the call in the check to see if the URL HTTP 'Head' request is successful will not succeed for private datasets. This is really an NCEAS problem, and I will log an issue for it. It may be helpful to provide a more useful message if an HTTP 401 (Not authorized) message is returned. The check would have to be updated to detect this.
will do, thx. URL in metadata
yes, that is indeed the problem, the check will be fixed. Funding Organization
OK, the check will be updated. Please let me know if we need to discuss these further, or if any of your questions haven't been answered sufficiently. |
Issue #423 Changed these checks to optional: - resource.projectTitle.controlled - resource.awardFunderName.controlled - metadata.identifier.resolvable - entity.type.nonproprietary
@Val @JEDamerow issues reported with the new checks have been resolved and the ESS-DIVE 1.1.0 suite has been run for all current metadata. However, for at least one metadata document, there is an issue with the mediaType (formatId) associated with the EML entity. For example, for 'https://data.ess-dive.lbl.gov/view/ess-dive-fe751bc7ce7851b-20210930T015111122080':
The sysmeta for this entry has the
I downloaded the file, and it is definitely a CSV, so both the metadata and sysmeta should identify this as There may be other metadata/sysmeta that have this same problem. The check works as it is supposed to, as it uses the mediaType recorded in the metadata. I'll continue to look for other pids that have this problem. |
The ESS-DIVE 1.1.0 suite is now running on production k8s and the release is available here. |
Description
Update the ESS-DIVE assessment suite based on the checks described here.
The new version number will be 1.1.0
Note that some of these checks are new and some are currently part of the FAIR suite.
List of checks for version 1.1.0:
The text was updated successfully, but these errors were encountered: