Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of sessions ina comparison report #17

Open
andreyzhd opened this issue Sep 28, 2023 · 1 comment
Open

Wrong order of sessions ina comparison report #17

andreyzhd opened this issue Sep 28, 2023 · 1 comment
Assignees

Comments

@andreyzhd
Copy link
Collaborator

When creating a comparison web report from two sessions:
The order of the videos in the report depends on the order in which the sessions were chosen, but ...
The order in which line styles (solid, dashed) are assigned to the sessions does not.

That is, reverting the order in which the sessions are chosen results in videos being swapped, but the plots remain exactly the same.
The desired behavior is for the plots to change too.

@andreyzhd andreyzhd self-assigned this Sep 28, 2023
@jjnurminen
Copy link
Collaborator

The web report delegates figure creation to the Plotly plotter. Looking at it quickly, my first hunch is that the plotter is designed to be invariant to the ordering of trials given as its argument. Therefore, it doesn't matter whether session 1 or session 2 trials come first in its input. This may be even be desirable, i.e. might be good to think about whether changing it will cause side effects in some circumstances.

The code at and around the following line might be relevant:

allcycles = sorted(cyclebunch.allcycles, key=sorter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants