Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set hideByline if not already set #571

Merged
merged 2 commits into from
Jan 8, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove check for hidebyline
gunnarvelle committed Jan 8, 2025
commit 31470a09b4cb3d4359a40c85e1f6c8c4c6d4a91e
Original file line number Diff line number Diff line change
@@ -31,10 +31,7 @@ trait V66__SetHideBylineForImagesNotCopyrighted {
doc
.select("ndlaembed[data-resource='image']")
.forEach(embed => {
val noHideByline = !embed.hasAttr("data-hide-byline")
if (noHideByline) {
ids += embed.attr("data-resource_id")
}
ids += embed.attr("data-resource_id")
})
if (ids.result().isEmpty) {
return doc