-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hot reload #20
Comments
Remember that "Don't ask again" ( NEARBuilders/bos-workspace#114 ) does not work with the redirect map. I believe that rather than using a redirectmap, a local RPC proxy should be provided that intercepts the calls that the VM does to get widget content, replacing the result with local widget content. Maybe we should solve that part in bos-workspace first? So that it is possible to use "Don't ask again"? |
I just investigated #114 and found the issue: it was misuse of the "commander" package for the cli. I've opened a pull request here to fix it. With this change, I have confirmed that disabling hot reload ( Now regarding redirectmap, maybe we should discuss more for clarity: In the pull request #26, the "useRedirectMap" hook handles three scenarios:
I agree that rpc proxy is much better and replaces the need for 1 + 2 -- and if we had to keep supporting one of these two, I would only keep session storage, because using bosLoaderUrl can be unpredictable (e.g. what port is it running on?). Although if we don't need to support either, that'd be nice too! My hope is to replace bos-workspace gateway with near-bos-webcomponent, and adding support for hot reload and ether.js are the only two items missing. And as shown in the fix, I think with hotreloadenabled = false, we can circumvent the redirectMap altogether and it will only use RPC proxy, satisfying the need when running a gateway for tests. |
This was merged with #26 |
In order to be able to fully replace the bos-workspace default gateway with near-bos-webcomponent, we need to introduce hot reloading.
Pull over the useRedirectHook from bos-workspace/gateway. This can also do some code clean-up in App.js -> Viewer, although maintain the "nearSocialVMredirectMap" SESSION_STORAGE_REDIRECT_MAP_KEY
Include documentation on how to use redirect map with hot reload (web socket) or session storage
The text was updated successfully, but these errors were encountered: