Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic termlists for a wider range of taxon groups #211

Open
kitenetter opened this issue Apr 16, 2021 · 25 comments
Open

Dynamic termlists for a wider range of taxon groups #211

kitenetter opened this issue Apr 16, 2021 · 25 comments

Comments

@kitenetter
Copy link
Collaborator

Dynamic termlists have now been implemented in iRecord. Can we enable similar behaviour in the app?

I'm not sure what needs to be done to make this happen, let me know if you need further information.

@kazlauskis
Copy link
Member

We already have some taxon group-specific dynamic attributes in the app :

  • bryophytes, butterflies and dragonflies (added in 2018)
  • plants/fungi and birds (added 2020)

Is this is the same thing we are talking about here? Are there some extra attributes/termlists that we should add?

@kazlauskis
Copy link
Member

I am not sure this is an issue so closing this for now.

@kitenetter
Copy link
Collaborator Author

@kazlauskis This is still an issue. We have a set of termlists for different taxon groups in iRecord. I would like the app to offer the same termlists as the website. I don't know what the technical implications of this are and what information you would need to enable this.

The terms we agreed on for the website are listed here:
dynamic termlists_stage.xlsx

John has implemented these in the warehouse:
BiologicalRecordsCentre/iRecord#812 (comment)

One potential problem is that you already have taxon-specific terms for some arthropod groups, so the new lists may have to be restricted to the groups you haven't already covered.

Let me know what else is required.

@kitenetter kitenetter reopened this May 28, 2021
@kazlauskis
Copy link
Member

We could do those in the app. I have had a look at the datasheet and the attributes we have implemented in the previous years and it looks like there is still a substantial discrepancy between the website, the app and the datasheet. e.g, dragonflies and bryophytes in the app have many more attributes, it also supports butterflies and DAFOR for plants/fungi. I think this deserves a zoom catch up to discuss the next steps in bringing these together. What do you think?

@cubitmg
Copy link

cubitmg commented May 28, 2021

One specific example is displaying the Method field, with appropriate values, when entering a casual record for insect-moth.

@kazlauskis
Copy link
Member

@kitenetter this ticket is unclear to me. Can you explain which fields in the app I should add/remove or shall we move the milestone to a later time until it is clearer?

@kitenetter
Copy link
Collaborator Author

@kazlauskis I don't think fields need to be added or removed, but the stage terms need to be matched to the website, so that if you record an insect or a flower you get the appropriate list of terms.

The terms we are using in the website are listed in the spreadsheet above. I don't currently have access to the app so I can't do a direct comparison.

@kazlauskis
Copy link
Member

The attributes in the data sheet are very different from what we have added in the app in the previous years. For example bryophytes attributes in the app are based on this form where in the document it is only a single attribute. Birds in the app have a Breeding attribute. Dragonflies (based on this form) and Butterflies in the app have many more attributes than the Arthropods in the document.

@kitenetter
Copy link
Collaborator Author

Sorry @kazlauskis I don't think I can say anything useful until I am able to view the app again, which I won't be able to do until the end of July.

@kitenetter
Copy link
Collaborator Author

This issue has come up again, for moth records, where the much-disliked term "pre-adult" is still in use in the app (when adding individual records). Picking up on the previous comment from @kazlauskis I think what is needed is:

  • For all taxon groups that don't already have custom stage terms in the app, use the appropriate stage terms from the spreadsheet

Is this possible? Do you need a list of the taxon groups that need to change, or is it easy to pick out everything that does not already have a custom stage term?

@kazlauskis
Copy link
Member

@kitenetter I am adding moth stage terms. Would you like me to include all of the arthropod stages? Also, do we have a “cocoon” term warehouse id now?

Also, I need to add this moth stage occurrence attribute to the app survey in the warehouse too. Do you know if there is an existing warehouse occurrence attribute that would use the “Import-Stage” termlist (id=136) or should I create a new one?

Id Term
1997 adult
2001 pupa
cocoon
10653 exuvia
2003 larva
7805 leaf-mine
7804 larval case
7803 larval web
3204 nymph
10656 gall
7806 egg
10551 other
10657 not recorded

@kitenetter
Copy link
Collaborator Author

@kazlauskis I have added the term "Cocoon" with ID 20553 in termlist ID 136.

However, for moths the best termlist to use is ID 138, which is used for the iRecord moths recording form, and is linked to occurrence attribute ID 130.

For other arthropods, the best termlist to use is ID 891, which is used for the iRecord moths recording form, and is linked to occurrence attribute ID 829.

If you have to use termlist ID 136, it is linked to occurrence attribute ID 124.

@kazlauskis
Copy link
Member

I see, we already use the moths' stage occAttr:130 in the moth survey in the app. Should we use the same 130 attribute in the general survey for moths as well then?

@kitenetter
Copy link
Collaborator Author

Yes, I think so.

@kazlauskis
Copy link
Member

If you can tell me which of the informal groups fall under the arthropods category then I can try to enable the occAttr:829 stage attribute for arthropods:

{
  "65": "acarine",
  "66": "acorn worm",
  "67": "alga",
  "68": "amphibian",
  "69": "annelid",
  "70": "arrow worm",
  "71": "bacterium",
  "72": "beardworm",
  "73": "bird",
  "74": "bony fish",
  "75": "bryozoan",
  "77": "centipede",
  "78": "clubmoss",
  "79": "coelenterate",
  "80": "comb jelly",
  "81": "conifer",
  "82": "crustacean",
  "83": "diatom",
  "84": "echinoderm",
  "85": "entoproct",
  "86": "false scorpion",
  "87": "fern",
  "88": "flatworm",
  "89": "flower. plant",
  "90": "foraminiferan",
  "91": "fungoid",
  "92": "fungus",
  "93": "gastrotrich",
  "94": "ginkgo",
  "95": "hairworm",
  "96": "harvestman",
  "97": "hornwort",
  "218": "undetermined",
  "98": "horseshoe worm",
  "99": "horsetail",
  "100": "alderfly",
  "101": "beetle",
  "102": "booklouse",
  "103": "bristletail",
  "104": "butterfly",
  "105": "caddis fly",
  "106": "cockroach",
  "107": "dragonfly",
  "108": "earwig",
  "109": "flea",
  "111": "lacewing",
  "112": "louse",
  "113": "mayfly",
  "114": "moth",
  "115": "orthopteran",
  "116": "scorpion fly",
  "117": "silverfish",
  "118": "snakefly",
  "119": "stick insect",
  "120": "stonefly",
  "121": "stylops",
  "122": "thrips",
  "123": "true bug",
  "124": "true fly",
  "125": "jawless fish",
  "126": "lampshell",
  "127": "lancelet",
  "128": "lichen",
  "129": "liverwort",
  "130": "marine mammal",
  "131": "millipede",
  "132": "mollusc",
  "133": "moss",
  "134": "peanut worm",
  "135": "priapulid",
  "136": "protozoan",
  "137": "quillwort",
  "138": "reptile",
  "139": "ribbon worm",
  "140": "rotifer",
  "141": "roundworm",
  "142": "sea spider",
  "143": "slime mould",
  "144": "spider",
  "145": "sponge",
  "146": "spoon worm",
  "147": "springtail",
  "148": "stonewort",
  "149": "symphylan",
  "150": "mammal",
  "151": "tunicate",
  "152": "two-tailed bristletail",
  "153": "unassigned",
  "154": "waterbear",
  "159": "trematode",
  "160": "tapeworm",
  "162": "scorpion",
  "110": "hymenopteran",
  "168": "chromist",
  "172": "gnathostomulid",
  "174": "cycliophoran",
  "179": "proturan",
  "181": "loriciferan",
  "182": "mud dragon",
  "188": "mesozoan",
  "191": "mantis",
  "194": "pauropod",
  "76": "cartilagenous fish",
  "219": "monogenean",
  "226": "thorny-headed worm",
  "239": "cyanobacterium",
  "240": "web-spinner"
}

@kitenetter
Copy link
Collaborator Author

kitenetter commented Nov 10, 2022

@kazlauskis the following groups are arthropods (note that butterflies, moths and dragonflies are included in this list but you will presumably want to exclude them because they already have custom stage terms):

"65": "acarine",
"77": "centipede",
"82": "crustacean",
"86": "false scorpion",
"96": "harvestman",
"100": "alderfly",
"101": "beetle",
"102": "booklouse",
"103": "bristletail",
"104": "butterfly",
"105": "caddis fly",
"106": "cockroach",
"107": "dragonfly",
"108": "earwig",
"109": "flea",
"110": "hymenopteran",
"111": "lacewing",
"112": "louse",
"113": "mayfly",
"114": "moth",
"115": "orthopteran",
"116": "scorpion fly",
"117": "silverfish",
"118": "snakefly",
"119": "stick insect",
"120": "stonefly",
"121": "stylops",
"122": "thrips",
"123": "true bug",
"124": "true fly",
"131": "millipede",
"142": "sea spider",
"144": "spider",
"147": "springtail",
"149": "symphylan",
"152": "two-tailed bristletail",
"162": "scorpion",
"191": "mantis",
"194": "pauropod",
"240": "web-spinner",`

@kazlauskis
Copy link
Member

I've added the moth and arthropod stage attributes to the app now. Leaving the ticket open since in your spreadsheet there are more attributes to sync with the app.

@Sam-Amy
Copy link

Sam-Amy commented Jun 26, 2024

The options given for vascular plants (not ferns) in the casual records form don't currently match the plant survey in the app:

<style> </style>
App - plant form App - casual record
Not Recorded Not Recorded
Flowering Flowering
Fruiting Fruiting
Juvenile Vegetative
Mature Seedling
Seedling  
Vegetative  

@Sam-Amy
Copy link

Sam-Amy commented Jun 26, 2024

I notice now this comes from the fact that the termlist created for the dynamic stage termlist for vascular plants (888) is the one used in on the app casual record (and web casual form), whereas the list used in the app/web vascular plant survey forms is from termlist 415. @kitenetter @sacrevert do you know why there is this discrepancy? If the longer list is preferable as I suspect @sacrevert I will add the extra terms to the termlist 888 so they all appear on the web casual form.

@japonicus
Copy link

The 'juvenile' and 'mature' terms are a bit odd and wouldn't usually be used for plant recording. I'd be happy for them to be dropped from the plant stage list.

@sacrevert
Copy link
Collaborator

@Sam-Amy I think this must be an oversight. All the vascular plant forms should use 888, effectively dropping the terms that @japonicus takes issue with.

@sacrevert
Copy link
Collaborator

sacrevert commented Sep 4, 2024

Note there is another aspect to the plant aspect of this issue, which is that, within the plant survey, the bryophytes should pick-up the bryophyte term lists used here (https://irecord.org.uk/enter_bryophyte_records), currently they just inherit the vascular plant/fern ones within that survey (i.e. it is assumed that all taxa within the plant survey take the same dynamic termlist, but this is not true). (see also #177 )

@sacrevert
Copy link
Collaborator

Also noting potential link to #142

@kitenetter
Copy link
Collaborator Author

I will review whether there is further work needed here for the animal groups in the app. @sacrevert is there still any issue for any of the plant groups?

@kitenetter kitenetter modified the milestones: 6.2.0, NCEA app work Jan 9, 2025
@kitenetter kitenetter self-assigned this Jan 9, 2025
@sacrevert
Copy link
Collaborator

  1. bryophytes within the Plant Survey do not inherit the bryophyte attribute list (which they do when recorded outside of the Plant Survey in the app)
  2. Vascular plant Stage list within Plant Survey should not have the options "juvenile" and "mature"
  3. Vascular plant Stage list outside of the Plant Survey is completely erroneous (has adult, pre-adult etc.)
  4. Vascular plant abundance list outside of the Plant Survey has the ranges which can be dropped (this could also be harmonised in its presentation of DAFOR/LA/LF/count with the Abundance attribute within the Plant Survey for vascular plants
  5. Vascular plants both within and outside of Plant Survey are lacking Altitude attribute available via plant form (https://irecord.org.uk/enter-vascular-plants)
  6. Bryophytes, both within and outside Plant Survey lack the free text "Visited habitats" and "Altitude" attributes available at https://irecord.org.uk/enter_bryophyte_records

I think that is it for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants