Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email, date and url fields are validated #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sundraiz-Shah
Copy link
Collaborator

No description provided.

@Aidajafarbigloo
Copy link
Collaborator

@Sundraiz-Shah, thank you for the updates. After testing the UI, I observed the following issues:

  • When editing URLs and attempting to download the JSON, after an error alert is triggered, the page displays the message: An unexpected error occurred: cannot unpack non-iterable NoneType object.
  • The error alert occurs even if the URL fields are left empty, which seems incorrect since these fields are not mandatory, and users should be able to leave them blank.
  • If the user changes the URL to https://gitlab.com/zdin-zle/zle-platform/repository/me, it still passes validation despite returning a 404 error. This could be problematic as the URL is not actually valid unless we want to check only the format and not its accessibility.
  • Regarding parsing the names, some email addresses still contain numbers after extraction.
  • Email validation in the Contributor table does not work, either after extraction or editing an existing email address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants