Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo on page 29 #22

Open
rgknox opened this issue Apr 22, 2020 · 2 comments
Open

typo on page 29 #22

rgknox opened this issue Apr 22, 2020 · 2 comments
Labels
typo Grammar or spelling error

Comments

@rgknox
Copy link
Collaborator

rgknox commented Apr 22, 2020

From a slack discussion with @adrifoster :

Hi Rosie & Ryan, I'm not sure if this is the correct/most updated place for the FATES doc (https://readthedocs.org/projects/fates-docs/downloads/pdf/latest/) but just FYI I found a typo on page 29:
"If 𝐴𝑓 is greater than a threshold value 𝐴𝑡, 𝑆𝑐 is increased by a small increment 𝑖. The threshold 𝐴𝑡 is, hypothetically, the canopy fraction at which light competition begins to impact on tree growth. This is less than 1.0 owing to the non-perfect spatial spacing of tree canopies. If 𝐴𝑓,𝑐𝑙 is greater than 𝐴𝑡, then 𝑆𝑐 is reduced by an increment 𝑖, to reduce the spatial extent of the canopy, thus."

I think the first "If A_f is.." should be "If A_f is less than" if I'm reading the code/equations correctly.

@rosiealice
Copy link
Contributor

Indeed. Good catch @adrifoster

I think the correction should probably be (notwithstanding that your's is also logically correct)
"If Af is learger than is greater than a threshold value 𝐴𝑡, 𝑆𝑐 is decreased by a
small increment 𝑖."
Because that is generally the order in which things happen. As in, the canopy expands and then Sc gets smaller first..

@adrifoster
Copy link

Okay cool, then the last sentence should also be changed to:

"If 𝐴𝑓,𝑐𝑙 is less than than 𝐴𝑡, then 𝑆𝑐 is increased by an increment 𝑖" and the "to reduce the spatial extent of the canopy" can be moved to the first sentence?

@glemieux glemieux added the typo Grammar or spelling error label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo Grammar or spelling error
Projects
None yet
Development

No branches or pull requests

4 participants