Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partitioned npp fluxes in history calculated after stem-counts change from mortality #1124

Open
Tracked by #1281
rgknox opened this issue Nov 28, 2023 · 0 comments
Open
Tracked by #1281

Comments

@rgknox
Copy link
Contributor

rgknox commented Nov 28, 2023

In the following line we assign the history output for NPP flux to leaves:

https://github.com/NGEET/fates/blob/sci.1.69.0_api.31.0.0/main/FatesHistoryInterfaceMod.F90#L3090-L3091

However, this flux is being calculated after disturbance and after non-disturbance mortality has been applied. In truth, we call allocation and growth before we call mortality and disturbance. Because of this, the model will allocate carbon in plants that are about to die.
Sad, yes. This carbon tracking is reflected accurately in the FATES mass balance checking, however, when we track this in history, we are not including those plants that grew and had died. They grew and should not be forgotten on their big final day.

We have had plans to split the history into a pre-disturbance and post-disturbance. This will come in after the implementation of this history density overhaul. The pre-disturbance history routine would be a great place to calculate these fluxes before their stem counts change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

No branches or pull requests

1 participant