Skip to content

Commit

Permalink
Merge pull request #33 from NHSLeadership/develop
Browse files Browse the repository at this point in the history
v1.1.0 Release
  • Loading branch information
tblacker7 authored Aug 12, 2020
2 parents 19a7d8c + 4752599 commit 99559a4
Show file tree
Hide file tree
Showing 19 changed files with 90 additions and 809 deletions.
2 changes: 1 addition & 1 deletion .distignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/vendor
/hookdocs


nightingale-companion.zip
.distignore
.gitignore
composer.json
Expand Down
18 changes: 6 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ Download the `nightingale-companion.zip` from this repository. Install this to y
## Additional Features this Plugin provides ##

### Display Options ###
- Retina Images - this enables your site to serve double quality images for retina display devices, and makes multiple
sizes for each of the sizes configured on your site. This all happens automatically in the background and will improve
the look of your thumbnails, images and banners across your site for retina capable screens.
- Disable Emojis - this disables the default emoji packages that ship with WordPress, which load on every single page
of your site and impact performance and speed. This is a tiny tweak that has an incremental benefit.
- Style login page - Modified the login page to use the theme design and layout
Expand All @@ -34,25 +31,22 @@ Download the `nightingale-companion.zip` from this repository. Install this to y
excerpt (or you can manually add your own per page/post). This modification uses this excerpt to populate the meta
description tag. If you have an alternative method of generating this meta tag, you should disable this option.
- Cleanup meta - removes lots of WP native tags included in the header region.
- Update jQuery - USE WITH CAUTION. This updates the jQuery for your WordPress to 3.4.1. The admin side is
unaffected. If enabling this, test ALL functionality of your site, as some plugin functionality for other plugins
on your site may cease to work as expected.


### Performance ###
- [LoadCSS](https://github.com/filamentgroup/loadCSS) - this uses the loadcss javascript library which defers loading of
your stylesheets to after the main html has loaded. This increases the speed of time to interaction for your pages
- [InstantPage](https://github.com/instantpage/instant.page) - this uses the instantpage javascript library to trigger
pages preloading when a user hovers their mouse over links. This does not, in fact increase load times but does appear perception of load times as those few partial
seconds pre click are actually being used to start loading the next page.
- DeferJS - adds a defer tag to all javascript (excluding jQuery and loadcss) to defer loading of js resources until
- Javascript Loading - Defaultss to native WP loading, but you can choose to instead:
- adds a defer tag to all javascript (excluding jQuery and loadcss) to defer loading of js resources until
after HTML has loaded in.
- Move Scripts to Footer - move the javascript and stylesheet files to the footer. This enables visible display of the page quicker.
- Both the above.
- Browser Cache - this is a setting to tell users' browser to cache locally the content. The value is number of
seconds that this local cache should be stored, defaulting to 43200 (12 hours)
- LazyLoading - adds a tag to all media resources to use native lazyloading. This will work on all modern
browsers (except FireFox)
- Compress HTML output - very basic minification of output HTML. This does not combine or minify included files. Will
reduce size of output HTML by around 3-5%
- Move Scripts to Footer - move the javascript and stylesheet files to the footer. This enables visible display of the page quicker.



### Blog Settings ###
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nhsleadership/nightingale-companion",
"version": "1.0.5",
"version": "1.1.0",
"dist": {
"url": "https://github.com/NHSLeadership/nightingale-companion/archive/master.zip",
"type": "zip"
Expand Down
27 changes: 12 additions & 15 deletions display/css/socialfloating.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
z-index: 10;
}
.contact-bar.left {
left: -40px;
left: -50px;
}
.contact-bar.right {
right: -40px;
right: -50px;
}

.contact-bar.slide-on-scroll {
Expand All @@ -26,13 +26,13 @@

.cb-link {
display: block;
width: 40px;
height: 40px;
width: 50px;
height: 50px;
padding: 0;
margin-bottom: 0.1em;
text-align: center;
line-height: 40px;
font-size: 17px;
line-height: 50px;
font-size: 20px;
background: #8e8e93;
color: #fff;
position: relative;
Expand All @@ -47,12 +47,12 @@
}
.left .cb-link {
left: 0;
border-radius: 0 0.4em 0.4em 0;
border-radius: 0;
border: 1px solid #425563;
}
.right .cb-link {
right: 0;
border-radius: 0.4em 0 0 0.4em;
border-radius: 0;
border: 1px solid #425563;
}
.cb-link .icon {
Expand All @@ -62,21 +62,18 @@
.left .cb-link:focus,
.left .cb-link:active {
color: #fff;
padding-left: 10px;
width: 50px;

}
.right .cb-link:hover,
.right .cb-link:focus,
.right .cb-link:active {
color: #fff;
padding-right: 10px;
width: 50px;
}
.left .cb-link.cb-hidden {
left: -40px;
left: -50px;
}
.right .cb-link.cb-hidden {
right: -40px;
right: -50px;
}

.cb-link.separated {
Expand All @@ -92,5 +89,5 @@
border: 0;
outline: 0;
padding: 0;
width: 40px;
width: 50px;
}
6 changes: 2 additions & 4 deletions display/display-enhancements.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
* @copyright NHS Leadership Academy, Tony Blacker
* @version 1.0 25th June 2020
*/
if ( ( isset( $nightingale_companion_options[ 'retina_images' ] ) ) && ( $nightingale_companion_options[ 'retina_images' ] === 'on' ) ) {
require_once( plugin_dir_path( __FILE__ ) . 'retina-images.php' );
}


if ( ( isset( $nightingale_companion_options[ 'style_login_page' ] ) ) && ( $nightingale_companion_options[ 'style_login_page' ] === 'on' ) ) {
require_once( plugin_dir_path( __FILE__ ) . 'login.php' );
Expand Down Expand Up @@ -56,7 +54,7 @@ function nightingale_companion_emergency_header( $content ) {
}

/**
* jQuery routine to take the output emergency alert and insert it into the corret area of the output html
* jQuery routine to take the output emergency alert and insert it into the correct area of the output html
*
* @since 1.0.0
* @hook nhsblocks_emergency_footer
Expand Down
100 changes: 0 additions & 100 deletions display/js/retina.js

This file was deleted.

2 changes: 1 addition & 1 deletion display/posts-by-author.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ function nightingale_companion_postsby_author( $content ) {
$content = $content . $output;
}

return $content;
wp_reset_postdata();
return $content;
}

add_action( 'the_content', 'nightingale_companion_postsby_author' );
Expand Down
104 changes: 0 additions & 104 deletions display/retina-images.php

This file was deleted.

14 changes: 0 additions & 14 deletions functionality/jquery-update.php

This file was deleted.

Loading

0 comments on commit 99559a4

Please sign in to comment.