Skip to content

Commit

Permalink
Merge pull request #58 from NHSLeadership/DI-5336
Browse files Browse the repository at this point in the history
DI-5336 Removed InstantPage from the plugin
  • Loading branch information
maheshmuralip authored May 11, 2023
2 parents 7311a6d + a9c32c3 commit b4936ce
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 40 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Download the `nightingale-companion.zip` from this repository. Install this to y
- REMOVED - [LoadCSS](https://github.com/filamentgroup/loadCSS) - this uses the loadcss javascript library which defers
loading of
your stylesheets to after the main html has loaded. This increases the speed of time to interaction for your pages
- [InstantPage](https://github.com/instantpage/instant.page) - this uses the instantpage javascript library to trigger
- REMOVED - [InstantPage](https://github.com/instantpage/instant.page) - this uses the instantpage javascript library to trigger
pages preloading when a user hovers their mouse over links. This does not, in fact increase load times but does appear perception of load times as those few partial
seconds pre click are actually being used to start loading the next page.
- REMOVED - Javascript Loading - Defaultss to native WP loading, but you can choose to instead:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nhsleadership/nightingale-companion",
"version": "1.3.5",
"version": "1.3.6",
"dist": {
"url": "https://github.com/NHSLeadership/nightingale-companion/archive/master.zip",
"type": "zip"
Expand Down
3 changes: 1 addition & 2 deletions nightingale-companion.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* License: GPL v3
* Requires at least: 5.0
* Tested up to: 6.0
* Version: 1.3.5
* Version: 1.3.6
*
* @package nightingale-companion
*/
Expand Down Expand Up @@ -65,7 +65,6 @@ function nightingale_companion_activate() {
function nightingale_companion_default_values() {
$defaults = array(
'loadcss' => 'on', // Enable Load CSS
'instantpage' => 'on', // Enable InstantPage
'javascript_loading' => 'none', // Enable Defer JS
'browser_cache' => '43200', // Set Browser Cache to 12 hours
'disable_emojis' => 'on', // Disable Emojis
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nightingale-companion",
"version": "1.3.5",
"version": "1.3.6",
"license": "GPL-3.0-or-later",
"main": "nightingale-companion.php",
"scripts": {
Expand Down
21 changes: 0 additions & 21 deletions performance/instantpage.php

This file was deleted.

4 changes: 0 additions & 4 deletions performance/performance-enhancements.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
// load css stuff.
// removed

// instantpage stuff.
if ( ( isset( $nightingale_companion_options[ 'instantpage' ] ) ) && ( $nightingale_companion_options[ 'instantpage' ] === 'on' ) ) {
require_once( plugin_dir_path( __FILE__ ) . 'instantpage.php' );
}

// defer JS loading to footer.
// removed
Expand Down
8 changes: 6 additions & 2 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Tags: theme, nightingale, nhs
Plugin Name:: Nightingale Companion
Requires at least: 5.0
Tested up to: 6.0
Stable tag: 1.3.5
Stable tag: 1.3.6
Requires PHP: 5.6
License: GPLv3 or later
License URI: https://www.gnu.org/licenses/gpl-3.0.html
Expand All @@ -22,7 +22,7 @@ enabled by default on installation but can be switched off easily via the admin
- Disable Emojis - this disables the default emoji packages that ship with WordPress, which load on every single page
of your site and impact performance and speed. This is a tiny tweak that has an incremental benefit.
- LoadCSS - Removed as caused a number of conflicts with some WP plugins.
- InstantPage - this uses the instantpage javascript library (https://github.com/instantpage/instant.page) to trigger
- InstantPage - Removed as causing multiple issues on the sites.
pages preloading when a user hovers their mouse over links. This does not, in fact increase load times but does appear perception of load times as those few partial
seconds pre click are actually being used to start loading the next page.
- DeferJS - Removed as caused a number of conflicts with some WP plugins.
Expand Down Expand Up @@ -68,6 +68,10 @@ with sample content on a site running the Nightingale theme, this plgin and the

== Changelog ==

= 1.3.6 =

-Removed InstantPage

= 1.3.5 =

-Fix php warning when there is no social sharing configured.
Expand Down
6 changes: 0 additions & 6 deletions settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@
'performance-options' => array(
'title' => __( 'Performance Options', 'nightingale' ),
'fields' => array(
'instantpage' => array(
'title' => 'InstantPage',
'type' => 'checkbox',
'checked' => 'true',
'text' => 'Enable instantpage library - this starts a page loading when a mouse hovers over it which improves User Experience',
),
'disable_emojis' => array(
'title' => 'Disable Emojis',
'type' => 'checkbox',
Expand Down

0 comments on commit b4936ce

Please sign in to comment.