Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Table #218

Open
penpadstudio opened this issue Apr 11, 2018 · 7 comments
Open

Table #218

penpadstudio opened this issue Apr 11, 2018 · 7 comments

Comments

@penpadstudio
Copy link
Contributor

Need to create following table format for programmes cohort tab page:
screen shot 2018-04-11 at 10 15 28

@cehwitham
Copy link
Member

@pro-paul is this different to plain table styles?

@penpadstudio
Copy link
Contributor Author

only slight changes... you can see what we have built here and the differences:
screen shot 2018-04-11 at 15 48 51

@cehwitham
Copy link
Member

@pro-paul thanks. Are these modifier styles for the tables or an override for the default style?

@penpadstudio
Copy link
Contributor Author

@cehwitham I think they should be modifier styles but I will leave it up to you and how best to build it. Not sure which would be more beneficial in the long run.

@cehwitham
Copy link
Member

So we want to keep the original default styling for tables but have this as an option?

@cehwitham
Copy link
Member

@pro-paul Is the front of the table data a dark grey?

What are the font-sizes?

Is the last column always right aligned or optional right alignment for last / any column?

@penpadstudio
Copy link
Contributor Author

@cehwitham

So we want to keep the original default styling for tables but have this as an option?

Correct.

Is the front of the table data a dark grey?

Yes they were but for v1 release they were changed back to # 231F20

What are the font-sizes?

Title headings: 24px H3
Column headings: 18px H4
Table text: 14px Supporting para

Is the last column always right aligned or optional right alignment for last / any column?

Last column is alway right aligned unless we run into a use case when we need an exception.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants