This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Typeography #260
Open
Typeography #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2018 11:41
- Swapped margins to small - Link colour corrections - Quote colour corrections - Made Index highlight typography examples -
- added Nightingale logo - Breadcrumbs styleing update - Edited intro text to framework - Many building edits on typography styling. - Update to quote box colour - Alert card heading change sizing -
cehwitham
suggested changes
Sep 7, 2018
There was a problem hiding this comment.
@pro-paul just a few comments to reply to. Can you resolve the merge conflicts so that the code is ready to merge please? @Android63 could help next week if you need some assistance with this. You can also merge the newer changes into this branch so you can test before merging into develop also.
settings/_settings.colors.scss
Outdated
| @@ -42,7 +42,7 @@ $color-warning: color('warning') !default; | |||
| // ========================================================================== */ | |||
|
|
|||
| $color-links: color('nhs-blue') !default; | |||
| $color-links-hover: #8060a7 !default; | |||
| $color-links-hover: #4C8ECF !default; | |||
There was a problem hiding this comment.
Can we use lowercase letters in hex values please?
|
@cehwitham I have updated the conflicts and the branch has been tested and works properly. @Android63 No need to respond as have completed the task myself. |
uppercase hex to lowercase
cehwitham
approved these changes
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @cehwitham