Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Jokes #2

Open
tachodril opened this issue Sep 30, 2020 · 7 comments
Open

Add More Jokes #2

tachodril opened this issue Sep 30, 2020 · 7 comments

Comments

@tachodril
Copy link
Collaborator

tachodril commented Sep 30, 2020

Do you want to add any jokes to our collection that you think can make someone laugh?
Well, then, here you go - Add your joke to jokes.json file in the /data/ folder and make a pull request.

{
      "body":"Your joke here.",
      "category":"category here."
}

Note:

Do not make changes in any other files and maintain the Json format in the file.
Add only 1 joke in one PR. If you want to add more than 1, then make separate pull requests for each.

@andreepratama27
Copy link
Contributor

Hi can i take this?

@tachodril
Copy link
Collaborator Author

Hi can i take this?

yeah sure!

@andreepratama27
Copy link
Contributor

Thanks. Please assign me to this task

@tachodril
Copy link
Collaborator Author

Thanks. Please assign me to this task

All you need to do is fork this repo, clone it, make changes, commit them and create a pull request.

@Rehannah
Copy link
Contributor

Rehannah commented Oct 6, 2020

Could jokes have more than one category?

@tachodril
Copy link
Collaborator Author

Could jokes have more than one category?

@Rehannah Yes, a joke can have more than one category.
Just separate them with comma as below -

{
      "body":"Your joke here.",
      "category":"category 1, category 2"
}

@srisatya12
Copy link

Hello @tachodril Sir can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants